Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2948005: remove handling of kernel verification block from recovery image (Closed)

Created:
10 years, 5 months ago by Tan Gao
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git/crosutils.git
Visibility:
Public.

Description

remove handling of kernel verification block from recovery image Change-Id: I749dc652651fdb02b49b290863e2fa9adc6b904e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M mod_image_for_recovery.sh View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tan Gao
Hi Andrew, This CL removes the obsolete code to copy kernel verification blocks in recovery ...
10 years, 5 months ago (2010-07-13 00:27:06 UTC) #1
adlr
10 years, 5 months ago (2010-07-13 00:38:35 UTC) #2
LGTM

On Mon, Jul 12, 2010 at 5:27 PM, <tgao@chromium.org> wrote:

> Reviewers: adlr,
>
> Message:
> Hi Andrew,
>
> This CL removes the obsolete code to copy kernel verification blocks in
> recovery
> image since Bill's CL already implemented this.
>
> PTAL thx
> Tan
>
> Description:
> remove handling of kernel verification block from recovery image
>
> Change-Id: I749dc652651fdb02b49b290863e2fa9adc6b904e
>
> Please review this at http://codereview.chromium.org/2948005/show
>
> SVN Base: ssh://git@chromiumos-git/crosutils.git
>
> Affected files:
>  M mod_image_for_recovery.sh
>
>
> Index: mod_image_for_recovery.sh
> diff --git a/mod_image_for_recovery.sh b/mod_image_for_recovery.sh
> index
>
5d927f1931c547e9205613de7e2320342cba8877..faa240c3cd7560f665f8559d73271895e842b7ff
> 100755
> --- a/mod_image_for_recovery.sh
> +++ b/mod_image_for_recovery.sh
> @@ -46,11 +46,6 @@ mount_gpt_cleanup() {
>  # Modifies an existing image for recovery use
>  update_recovery_packages() {
>   local image_name=$1
> -  local sector_size=512  # sector size in bytes
> -  local num_sectors_vb=128  # number of sectors in kernel verification
> blob
> -  # Start offset of kernel A (aligned to 4096-sector boundary)
> -  local start_kern_a=4096
> -  local vb_file="${STATEFUL_FS_DIR}/verification_blob.kernel"
>
>   echo "Modifying image ${image_name} for recovery use"
>
> @@ -63,19 +58,6 @@ update_recovery_packages() {
>   # Mark the image as a recovery image (needed for recovery boot)
>   sudo touch "${STATEFUL_FS_DIR}/.recovery"
>
> -  # Copy verification blob out of kernel A into stateful partition
> -  # so that we can restore it during recovery
> -  sudo touch $vb_file
> -  echo "Backing up kernel verification blob onto stateful partition ..."
> -  sudo dd if="$image_name" of="$vb_file" skip=$start_kern_a
> bs=$sector_size \
> -      count=$num_sectors_vb conv=notrunc
> -
> -  # Overwrite verification blob with recovery image verification blob
> -  # TODO(tgao): resign kernel for recovery image
> -  echo "Overwrite kernel verification blob with resigned blob for
> recovery..."
> -  sudo dd if=/dev/zero of="$image_name" seek=$start_kern_a bs=$sector_size
> \
> -      count=$num_sectors_vb conv=notrunc
> -
>   trap - EXIT
>   ${SCRIPTS_DIR}/mount_gpt_image.sh -u -r "${ROOT_FS_DIR}" \
>       -s "${STATEFUL_FS_DIR}"
>
>
>

Powered by Google App Engine
This is Rietveld 408576698