Issue 2947002: Don't build rollback index test as part of 'all', since it depends on the real tlcl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2947002: Don't build rollback index test as part of 'all', since it depends on the real tlcl. (Closed)

Created:
10 years, 5 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Bill Richardson, Luigi Semenzato

Base URL:
ssh://gitrw.chromium.org/vboot_reference.git

Visibility:
Public.

Description

Don't build rollback index test as part of 'all', since it depends on the real tlcl. It'll still be built as part of 'make install'.

Patch Set 1 #

Patch Set 2 : Also disable building index test install #

Patch Set 3 : Missed a line #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	tests/Makefile	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

10 years, 5 months ago (2010-07-08 20:56:36 UTC) #2

On 2010/07/08 20:43:13, Randall Spangler wrote:
> 

LGTM, but we also need to comment out the installation in tests/Makefile with
something like this, because the ebuild does a make -C tests install.  For some
reason this doesn't build correctly, and it will break the build if not fixed.

install:
	echo no tests to install

# install: $(BUILD_ROOT)/rollback_index_test
#	mkdir -p $(DESTDIR)
#	cp -f $(BUILD_ROOT)/rollback_index_test $(DESTDIR)

Expand Messages | Collapse Messages