Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2946009: Fix wording of "plug-in". (Closed)

Created:
10 years, 5 months ago by Bernhard Bauer
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix wording of "plug-in". BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52306

Patch Set 1 #

Patch Set 2 : forgot a file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_strings.grd View 3 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bernhard Bauer
Please review.
10 years, 5 months ago (2010-07-12 17:10:02 UTC) #1
Nico
10 years, 5 months ago (2010-07-12 20:22:50 UTC) #2 
Cool!

LG.

On Mon, Jul 12, 2010 at 10:10 AM,  <bauerb@chromium.org> wrote:
> Reviewers: Nico,
>
> Message:
> Please review.
>
> Description:
> Fix wording of "plug-in".
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/2946009/show
>
> Affected files:
>  M chrome/app/generated_resources.grd
>  M webkit/glue/webkit_strings.grd
>
>
> Index: chrome/app/generated_resources.grd
> diff --git a/chrome/app/generated_resources.grd
> b/chrome/app/generated_resources.grd
> index
>
58706af70f4fca17cc418012a156d0ee5308be60..5b1389f2dc7a338f3832b0438e6ef66431331743
> 100644
> --- a/chrome/app/generated_resources.grd
> +++ b/chrome/app/generated_resources.grd
> @@ -3464,7 +3464,7 @@ each locale. -->
>         Could not load file '<ph
> name="RELATIVE_PATH">$1<ex>file.js</ex></ph>' for content script. It isn't
> UTF-8 encoded.
>       </message>
>       <message name="IDS_EXTENSION_LOAD_PLUGIN_PATH_FAILED" desc="">
> -        Could not load '<ph
> name="PLUGIN_PATH">$1<ex>/path/to/file</ex></ph>' for plugin.
> +        Could not load '<ph
> name="PLUGIN_PATH">$1<ex>/path/to/file</ex></ph>' for plug-in.
>       </message>
>       <message name="IDS_EXTENSION_LOAD_ICON_FOR_PAGE_ACTION_FAILED"
> desc="">
>         Could not load icon '<ph name="ICON">$1<ex>icon.png</ex></ph>' for
> page action.
> Index: webkit/glue/webkit_strings.grd
> diff --git a/webkit/glue/webkit_strings.grd b/webkit/glue/webkit_strings.grd
> index
>
4e11c1bb66db17cc50aa8efd8536adf9e84c0809..8b2c57d1ae15c2bde44672180a9a8d0bed83b3a1
> 100644
> --- a/webkit/glue/webkit_strings.grd
> +++ b/webkit/glue/webkit_strings.grd
> @@ -295,31 +295,31 @@ below:
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_GET_PLUGIN_MSG" desc="Message
> displayed by the default plugin in its main window">
> -        <ph name="PLUGIN">$1<ex>Realplayer</ex></ph> plugin is not
> installed
> +        <ph name="PLUGIN">$1<ex>Realplayer</ex></ph> plug-in is not
> installed
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_GET_PLUGIN_MSG_NO_PLUGIN_NAME"
> desc="Message displayed by the default plugin in its main window when we
> don't know the plugin name">
> -        The required plugin is not installed
> +        The required plug-in is not installed
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_GET_PLUGIN_MSG_2" desc="Second
> Message displayed by the default plugin in its main window">
> -        Click here to download plugin
> +        Click here to download plug-in
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_REFRESH_PLUGIN_MSG" desc="Message
> displayed by the default plugin to refresh the window after installing the
> required plugin">
> -        After installing the plugin, click here to refresh
> +        After installing the plug-in, click here to refresh
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_NO_PLUGIN_AVAILABLE_MSG"
> desc="Message displayed by the default plugin when no plugin was found for
> the page.">
> -        No plugin available to display this content
> +        No plug-in available to display this content
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_DOWNLOADING_PLUGIN_MSG"
> desc="Message displayed by the default plugin when a download has been
> initiated for the third party plugin.">
> -        Downloading plugin...
> +        Downloading plug-in...
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_GET_THE_PLUGIN_BTN_MSG"
> desc="Message displayed by the default plugin on the button which the user
> should click to fetch the plugin.">
> -        Get Plugin
> +        Get Plug-in
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_CANCEL_PLUGIN_DOWNLOAD_MSG"
> desc="Message displayed by the default plugin on the button which the user
> should click to cancel the plugin download.">
> @@ -327,18 +327,18 @@ below:
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_CONFIRMATION_DIALOG_TITLE"
> desc="Default plugin confirmation dialog title.">
> -        <ph name="PLUGIN">$1<ex>Realplayer</ex></ph> plugin needed
> +        <ph name="PLUGIN">$1<ex>Realplayer</ex></ph> plug-in needed
>       </message>
>
>       <message
> name="IDS_DEFAULT_PLUGIN_CONFIRMATION_DIALOG_TITLE_NO_PLUGIN_NAME"
> desc="Default plugin confirmation dialog title when we don't know the plugin
> name">
> -        Additional plugin needed
> +        Additional plug-in needed
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_USER_OPTION_MSG" desc="Message
> displayed by the default plugin in the install dialog indicating information
> on the user action.">
> -        Please confirm that you would like to install the <ph
> name="PLUGIN">$1<ex>realplayer</ex></ph> plugin. You should only install
> plugins that you trust.
> +        Please confirm that you would like to install the <ph
> name="PLUGIN">$1<ex>realplayer</ex></ph> plug-in. You should only install
> plug-ins that you trust.
>       </message>
>       <message name="IDS_DEFAULT_PLUGIN_USER_OPTION_MSG_NO_PLUGIN_NAME"
> desc="Message displayed by the default plugin in the install dialog
> indicating information on the user action when we don't know the plugin
> name">
> -        Please confirm that you would like to install this plugin. You
> should only install plugins that you trust.
> +        Please confirm that you would like to install this plug-in. You
> should only install plug-ins that you trust.
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_USE_OPTION_CONFIRM" desc="Button to
> confirm installation of plugin">
> @@ -349,11 +349,11 @@ below:
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_DOWNLOAD_FAILED_MSG" desc="Message
> displayed by the default plugin when download is failed.">
> -        Failed to install plugin from <ph
> name="URL">$1<ex>http://www.google.com/blablah.exe</ex></ph>
> +        Failed to install plug-in from <ph
> name="URL">$1<ex>http://www.google.com/blablah.exe</ex></ph>
>       </message>
>
>       <message name="IDS_DEFAULT_PLUGIN_INSTALLATION_FAILED_MSG"
> desc="Message displayed by the default plugin when installation is failed.">
> -        Plugin installation failed
> +        Plug-in installation failed
>       </message>
>     </messages>
>   </release>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698