Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2945010: cros_workon: allow unmasking packages for the host (Closed)

Created:
10 years, 5 months ago by zbehan
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://gitrw.chromium.org/crosutils
Visibility:
Public.

Description

cros_workon: allow unmasking packages for the host modified: cros_workon

Patch Set 1 #

Patch Set 2 : ...and kill the tabs :/ #

Patch Set 3 : Fix 80 cols issue introduced in the last CL #

Total comments: 5

Patch Set 4 : changed constants to FLAGS_TRUE|FALSE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M cros_workon View 1 2 3 3 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
zbehan
10 years, 5 months ago (2010-07-10 01:20:59 UTC) #1
zbehan
10 years, 5 months ago (2010-07-10 01:23:22 UTC) #2
zbehan
10 years, 5 months ago (2010-07-10 04:01:21 UTC) #3
Mandeep Singh Baines
LGTM after fixing FLAGS_false issue http://codereview.chromium.org/2945010/diff/6001/7001 File cros_workon (right): http://codereview.chromium.org/2945010/diff/6001/7001#newcode23 cros_workon:23: DEFINE_boolean host "false" \ ...
10 years, 5 months ago (2010-07-12 20:54:56 UTC) #4
sosa
Note FALSE not false http://codereview.chromium.org/2945010/diff/6001/7001 File cros_workon (right): http://codereview.chromium.org/2945010/diff/6001/7001#newcode23 cros_workon:23: DEFINE_boolean host "false" \ On ...
10 years, 5 months ago (2010-07-12 21:08:51 UTC) #5
zbehan
10 years, 5 months ago (2010-07-12 21:12:50 UTC) #6
sosa
10 years, 5 months ago (2010-07-12 21:15:56 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698