Issue 2944016: Add ES5 Object.freeze and Object.isFrozen methods....

Issue 2944016: Add ES5 Object.freeze and Object.isFrozen methods.... (Closed)

Created:
10 years, 5 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add ES5 Object.freeze and Object.isFrozen methods. This change adds ES5 15.2.3.9 Object.freeze and 15.2.3.12 Object.isFrozen Committed: http://code.google.com/p/v8/source/detail?r=5055

Patch Set 4 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+215 lines, -11 lines)			Patch
M	src/v8natives.js	View	1	4 chunks	+41 lines, -1 line	0 comments	Download
M	test/es5conform/es5conform.status	View	1 2	1 chunk	+0 lines, -10 lines	0 comments	Download
A	test/mjsunit/object-freeze.js	View	1 2 3	1 chunk	+174 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/2944016/diff/6001/7003 File test/mjsunit/object-freeze.js (right): http://codereview.chromium.org/2944016/diff/6001/7003#newcode32 test/mjsunit/object-freeze.js:32: // Test that we throw an error if ...

10 years, 5 months ago (2010-07-13 12:45:31 UTC) #2

Rico

10 years, 5 months ago (2010-07-13 13:05:11 UTC) #3

http://codereview.chromium.org/2944016/diff/6001/7003
File test/mjsunit/object-freeze.js (right):

http://codereview.chromium.org/2944016/diff/6001/7003#newcode32
test/mjsunit/object-freeze.js:32: // Test that we throw an error if the an
object is not passed as argument.
On 2010/07/13 12:45:31, Mads Ager wrote:
> the an -> an

Done.

http://codereview.chromium.org/2944016/diff/6001/7003#newcode53
test/mjsunit/object-freeze.js:53: var obj = {x: 42, z: 'foobar'};
On 2010/07/13 12:45:31, Mads Ager wrote:
> Space after { and before }?
> 
> Similarly in the rest of the file.

Done.

http://codereview.chromium.org/2944016/diff/6001/7003#newcode97
test/mjsunit/object-freeze.js:97: // // Test on accessors.
On 2010/07/13 12:45:31, Mads Ager wrote:
> Remove extra //

Done.

http://codereview.chromium.org/2944016/diff/6001/7003#newcode122
test/mjsunit/object-freeze.js:122: obj2.foo = 42;
On 2010/07/13 12:45:31, Mads Ager wrote:
> Identation off.

Done.

Expand Messages | Collapse Messages