net/socket/ssl_client_socket_openssl.cc - Issue 2944008: Refactor X509Certificate caching to cache the OS handle, rather than the X509Certificate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 2944008: Refactor X509Certificate caching to cache the OS handle, rather than the X509Certificate (Closed)

Patch Set: Removed unnecessary bits Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_openssl.cc

diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc

index 3e25e2bb2b3877b8f208d33f5028c05451c58581..b54e439394b65c84cea869384ffee379b88dee39 100644

--- a/net/socket/ssl_client_socket_openssl.cc

+++ b/net/socket/ssl_client_socket_openssl.cc

@@ -869,8 +869,8 @@ X509Certificate* SSLClientSocketOpenSSL::UpdateServerCert() {

for (int i = 0; i < sk_X509_num(chain); ++i)

intermediates.push_back(sk_X509_value(chain, i));

}

- server_cert_ = X509Certificate::CreateFromHandle(

- cert.get(), X509Certificate::SOURCE_FROM_NETWORK, intermediates);

+ server_cert_ = X509Certificate::CreateFromHandle(cert.get(),

+ intermediates);

wtc 2011/07/17 01:55:32 This may fit on the previous line.

DCHECK(server_cert_);

return server_cert_;