net/base/x509_certificate_nss.cc - Issue 2944008: Refactor X509Certificate caching to cache the OS handle, rather than the X509Certificate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate_nss.cc

Issue 2944008: Refactor X509Certificate caching to cache the OS handle, rather than the X509Certificate (Closed)

Patch Set: Removed unnecessary bits Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_certificate_nss.cc

diff --git a/net/base/x509_certificate_nss.cc b/net/base/x509_certificate_nss.cc

index 945e7cfc681781db8db33cdbf0333d5b49467e4a..699c65502321e2dce387a8ca67328f889ee3d409 100644

--- a/net/base/x509_certificate_nss.cc

+++ b/net/base/x509_certificate_nss.cc

@@ -749,8 +749,7 @@ X509Certificate* X509Certificate::CreateSelfSigned(

// Save the signed result to the cert.

cert->derCert = *result;

- X509Certificate* x509_cert =

- CreateFromHandle(cert, SOURCE_LONE_CERT_IMPORT, OSCertHandles());

+ X509Certificate* x509_cert = CreateFromHandle(cert, OSCertHandles());

CERT_DestroyCertificate(cert);

return x509_cert;

}