net/base/cert_database_nss_unittest.cc - Issue 2944008: Refactor X509Certificate caching to cache the OS handle, rather than the X509Certificate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/cert_database_nss_unittest.cc

Issue 2944008: Refactor X509Certificate caching to cache the OS handle, rather than the X509Certificate (Closed)

Patch Set: Rebase to trunk after splitting out 4645001 Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/cert_database_nss_unittest.cc

diff --git a/net/base/cert_database_nss_unittest.cc b/net/base/cert_database_nss_unittest.cc

index 8e691041e96803ef6114349a93df174b08099f9e..06d9e3e8514be84e22149c5819ba78aac1748e82 100644

--- a/net/base/cert_database_nss_unittest.cc

+++ b/net/base/cert_database_nss_unittest.cc

@@ -50,11 +50,8 @@ CertificateList ListCertsInSlot(PK11SlotInfo* slot) {

for (CERTCertListNode* node = CERT_LIST_HEAD(cert_list);

!CERT_LIST_END(node, cert_list);

node = CERT_LIST_NEXT(node)) {

- result.push_back(

- X509Certificate::CreateFromHandle(

- node->cert,

- X509Certificate::SOURCE_LONE_CERT_IMPORT,

- X509Certificate::OSCertHandles()));

+ result.push_back(X509Certificate::CreateFromHandle(

+ node->cert, X509Certificate::OSCertHandles()));

}

CERT_DestroyCertList(cert_list);