Issue 2943006: Use WaitForNotification instead of busy loop.

Issue 2943006: Use WaitForNotification instead of busy loop. (Closed)

Created:
10 years, 5 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
zel, Paweł Hajdan Jr.

CC:
chromium-reviews, ben+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Use WaitForNotification instead of busy loop. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52794

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	chrome/browser/chromeos/network_state_notifier_browsertest.cc	View	1 2	2 chunks	+3 lines, -8 lines	0 comments	Download

Total messages: 7 (0 generated)

oshima

fyi: chromeos trybot is currently broken and not due to my change. I'm going to ...

10 years, 5 months ago (2010-07-13 00:22:42 UTC) #1

Paweł Hajdan Jr.

The change looks fine to me, and is fairly simple, but it'd be better if ...

10 years, 5 months ago (2010-07-13 03:41:05 UTC) #2

oshima

On 2010/07/14 19:03:10, oshima wrote: > zel, can you take a look? ping?

10 years, 5 months ago (2010-07-16 02:43:41 UTC) #4

Paweł Hajdan Jr.

This is taking ridiculously long for such simple change. You got my LGTM. :)

10 years, 5 months ago (2010-07-16 18:19:47 UTC) #5

oshima

On Fri, Jul 16, 2010 at 11:19 AM, <phajdan.jr@chromium.org> wrote: > This is taking ridiculously ...

10 years, 5 months ago (2010-07-16 18:22:32 UTC) #6

LGTM