Add exception management on invalid codereview.settings.

gcl.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 157 matching lines @@
 
 
 def GetCodeReviewSetting(key):
   """Returns a value for the given key for this repository."""
   # Use '__just_initialized' as a flag to determine if the settings were
   # already initialized.
   if '__just_initialized' not in CODEREVIEW_SETTINGS:
     settings_file = GetCachedFile(CODEREVIEW_SETTINGS_FILE)
     if settings_file:
       for line in settings_file.splitlines():
-        if not line or line.startswith("#"):
+        if not line or line.startswith('#'):
           continue
-        k, v = line.split(": ", 1)
+        if not ':' in line:
+          raise gclient_utils.Error(
+              '%s is invalid, please fix. It\'s content:\n\n%s' %
+                  (CODEREVIEW_SETTINGS_FILE, settings_file))
+        k, v = line.split(': ', 1)
         CODEREVIEW_SETTINGS[k] = v
     CODEREVIEW_SETTINGS.setdefault('__just_initialized', None)
   return CODEREVIEW_SETTINGS.get(key, "")
 
 
 def Warn(msg):
   print >> sys.stderr, msg
 
 
 def ErrorExit(msg):
@@ skipping 1110 matching lines @@
     return command(argv[1:])
 
   try:
     GetRepositoryRoot()
   except gclient_utils.Error:
     print('To use gcl, you need to be in a subversion checkout.')
     return 1
 
   # Create the directories where we store information about changelists if it
   # doesn't exist.
-  if not os.path.exists(GetInfoDir()):
-    os.mkdir(GetInfoDir())
-  if not os.path.exists(GetChangesDir()):
-    os.mkdir(GetChangesDir())
-  if not os.path.exists(GetCacheDir()):
-    os.mkdir(GetCacheDir())
+  try:
+    if not os.path.exists(GetInfoDir()):
+      os.mkdir(GetInfoDir())
+    if not os.path.exists(GetChangesDir()):
+      os.mkdir(GetChangesDir())
+    if not os.path.exists(GetCacheDir()):
+      os.mkdir(GetCacheDir())
 
-  if command:
-    return command(argv[1:])
-  # Unknown command, try to pass that to svn
-  return CMDpassthru(argv)
-
+    if command:
+      return command(argv[1:])
+    # Unknown command, try to pass that to svn
+    return CMDpassthru(argv)
+  except gclient_utils.Error, e:
+    print('Got an exception')
+    print(str(e))
 
 if __name__ == "__main__":
   sys.exit(main(sys.argv[1:]))