Add optimized ICs for new CanvasArray types. This is a follow-on CL to...

test/cctest/test-api.cc

 // Copyright 2007-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 8179 matching lines @@
                       "  sum += tmp_array[i];"
                       "  if (i == 4) {"
                       "    tmp_array = {};"
                       "  }"
                       "}"
                       "sum;");
   i::Heap::CollectAllGarbage(false);  // Force GC to trigger verification.
   CHECK_EQ(28, result->Int32Value());
 
   // Check out-of-range loads.
-  result = CompileRun("var caught_exception = false;"
-                      "try {"
-                      "  ext_array[-1];"
-                      "} catch (e) {"
-                      "  caught_exception = true;"
-                      "}"
-                      "caught_exception;");
-  CHECK_EQ(true, result->BooleanValue());
-
   i::OS::SNPrintF(test_buf,
                   "var caught_exception = false;"
                   "try {"
                   "  ext_array[%d];"
                   "} catch (e) {"
                   "  caught_exception = true;"
                   "}"
                   "caught_exception;",
                   kElementCount);
   result = CompileRun(test_buf.start());
   CHECK_EQ(true, result->BooleanValue());
 
   // Check out-of-range stores.
-  result = CompileRun("var caught_exception = false;"
-                      "try {"
-                      "  ext_array[-1] = 1;"
-                      "} catch (e) {"
-                      "  caught_exception = true;"
-                      "}"
-                      "caught_exception;");
-  CHECK_EQ(true, result->BooleanValue());
-
   i::OS::SNPrintF(test_buf,
                   "var caught_exception = false;"
                   "try {"
                   "  ext_array[%d] = 1;"
                   "} catch (e) {"
                   "  caught_exception = true;"
                   "}"
                   "caught_exception;",
                   kElementCount);
   result = CompileRun(test_buf.start());
   CHECK_EQ(true, result->BooleanValue());
 
-  // TODO(kbr): check what happens during IC misses on the type of the object.
-  // Re-assign array object halfway through a loop.
-
   // Check other boundary conditions, values and operations.
   result = CompileRun("for (var i = 0; i < 8; i++) {"
                       "  ext_array[7] = undefined;"
                       "}"
                       "ext_array[7];");
   CHECK_EQ(0, result->Int32Value());
   CHECK_EQ(0, static_cast<int>(jsobj->GetElement(7)->Number()));
 
   result = CompileRun("for (var i = 0; i < 8; i++) {"
                       "  ext_array[6] = '2.3';"
                       "}"
                       "ext_array[6];");
   CHECK_EQ(2, result->Int32Value());
   CHECK_EQ(2, static_cast<int>(jsobj->GetElement(6)->Number()));
 
-  // Result for storing NaNs and +/-Infinity isn't defined for these
-  // types; they do not have the clamping behavior CanvasPixelArray
-  // specifies.
+  if (array_type != v8::kExternalFloatArray) {
+    // Though the specification doesn't state it, be explicit about
+    // converting NaNs and +/-Infinity to zero.
+    result = CompileRun("for (var i = 0; i < 8; i++) {"
+                        "  ext_array[i] = 5;"
+                        "}"
+                        "for (var i = 0; i < 8; i++) {"
+                        "  ext_array[i] = NaN;"
+                        "}"
+                        "ext_array[5];");
+    CHECK_EQ(0, result->Int32Value());
+    CHECK_EQ(0, i::Smi::cast(jsobj->GetElement(5))->value());
+
+    result = CompileRun("for (var i = 0; i < 8; i++) {"
+                        "  ext_array[i] = 5;"
+                        "}"
+                        "for (var i = 0; i < 8; i++) {"
+                        "  ext_array[i] = Infinity;"
+                        "}"
+                        "ext_array[5];");
+    CHECK_EQ(0, result->Int32Value());
+    CHECK_EQ(0, i::Smi::cast(jsobj->GetElement(5))->value());
+
+    result = CompileRun("for (var i = 0; i < 8; i++) {"
+                        "  ext_array[i] = 5;"
+                        "}"
+                        "for (var i = 0; i < 8; i++) {"
+                        "  ext_array[i] = -Infinity;"
+                        "}"
+                        "ext_array[5];");
+    CHECK_EQ(0, result->Int32Value());
+    CHECK_EQ(0, i::Smi::cast(jsobj->GetElement(5))->value());
+  }
 
   result = CompileRun("ext_array[3] = 33;"
                       "delete ext_array[3];"
                       "ext_array[3];");
   CHECK_EQ(33, result->Int32Value());
 
   result = CompileRun("ext_array[0] = 10; ext_array[1] = 11;"
                       "ext_array[2] = 12; ext_array[3] = 13;"
                       "ext_array.__defineGetter__('2',"
                       "function() { return 120; });"
@@ skipping 205 matching lines @@
 THREADED_TEST(GetHeapStatistics) {
   v8::HandleScope scope;
   LocalContext c1;
   v8::HeapStatistics heap_statistics;
   CHECK_EQ(heap_statistics.total_heap_size(), 0);
   CHECK_EQ(heap_statistics.used_heap_size(), 0);
   v8::V8::GetHeapStatistics(&heap_statistics);
   CHECK_NE(heap_statistics.total_heap_size(), 0);
   CHECK_NE(heap_statistics.used_heap_size(), 0);
 }