Add optimized ICs for new CanvasArray types. This is a follow-on CL to...

src/runtime.cc

 // Copyright 2006-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2562 matching lines @@
                               HandleVector(args, 2));
     return Top::Throw(*error);
   }
 
   // Check if the given key is an array index.
   uint32_t index;
   if (Array::IndexFromObject(*key, &index)) {
     return GetElementOrCharAt(object, index);
   }
 
-  // If the target object is a JSObject and has an ExternalArray as
-  // its elements, we need to check for negative indices and report
-  // exceptions. Indices larger than the array's length will be caught
-  // elsewhere.
-  if (key->IsSmi() && Smi::cast(*key)->value() < 0) {
-    if (object->IsJSObject() &&
-        JSObject::cast(*object)->HasExternalArrayElements()) {
-      uint32_t index = static_cast<uint32_t>(Smi::cast(*key)->value());
-      return Top::Throw(*Factory::NewIndexError(index));
-    }
-  }
-
   // Convert the key to a string - possibly by calling back into JavaScript.
   Handle<String> name;
   if (key->IsString()) {
     name = Handle<String>::cast(key);
   } else {
     bool has_pending_exception = false;
     Handle<Object> converted =
         Execution::ToString(key, &has_pending_exception);
     if (has_pending_exception) return Failure::Exception();
     name = Handle<String>::cast(converted);
@@ skipping 114 matching lines @@
     // assignments.
     if (js_object->IsStringObjectWithCharacterAt(index)) {
       return *value;
     }
 
     Handle<Object> result = SetElement(js_object, index, value);
     if (result.is_null()) return Failure::Exception();
     return *value;
   }
 
-  // If the target object is a JSObject and has an ExternalArray as
-  // its elements, we need to check for negative indices and report
-  // exceptions. Indices larger than the array's length will be caught
-  // elsewhere.
-  if (key->IsSmi() && Smi::cast(*key)->value() < 0) {
-    if (object->IsJSObject() &&
-        JSObject::cast(*object)->HasExternalArrayElements()) {
-      uint32_t index = static_cast<uint32_t>(Smi::cast(*key)->value());
-      return Top::Throw(*Factory::NewIndexError(index));
-    }
-  }
-
   if (key->IsString()) {
     Handle<Object> result;
     if (Handle<String>::cast(key)->AsArrayIndex(&index)) {
       ASSERT(attr == NONE);
       result = SetElement(js_object, index, value);
     } else {
       Handle<String> key_string = Handle<String>::cast(key);
       key_string->TryFlattenIfNotFlat();
       result = SetProperty(js_object, key_string, value, attr);
     }
@@ skipping 5119 matching lines @@
   } else {
     // Handle last resort GC and make sure to allow future allocations
     // to grow the heap without causing GCs (if possible).
     Counters::gc_last_resort_from_js.Increment();
     Heap::CollectAllGarbage(false);
   }
 }
 
 
 } }  // namespace v8::internal