Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1974)

Issue 294021: Add support for global variable references in toplevel code. We use... (Closed)

Created:
11 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add support for global variable references in toplevel code. We use the normal named load IC mechanism for now. Generated code is similar to the case for global variable assignments. Committed: http://code.google.com/p/v8/source/detail?r=3101

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -14 lines) Patch
M src/arm/fast-codegen-arm.cc View 1 chunk +20 lines, -4 lines 1 comment Download
M src/compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 chunk +24 lines, -4 lines 1 comment Download
M src/x64/fast-codegen-x64.cc View 1 chunk +23 lines, -4 lines 1 comment Download
M test/mjsunit/compiler/globals.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 2 months ago (2009-10-20 13:47:31 UTC) #1
fschneider
11 years, 2 months ago (2009-10-20 14:16:17 UTC) #2
LGTM.

http://codereview.chromium.org/294021/diff/1/6
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/294021/diff/1/6#newcode142
Line 142: if (rewrite == NULL) {
Insert a comment here:

Comment cmnt(masm_, "[Load from global property");

http://codereview.chromium.org/294021/diff/1/3
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/294021/diff/1/3#newcode132
Line 132: if (rewrite == NULL) {
Insert a comment here like:

Comment cmnt(masm_, "[Load from global property");

http://codereview.chromium.org/294021/diff/1/5
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/294021/diff/1/5#newcode149
Line 149: if (rewrite == NULL) {
Insert a comment here:

Comment cmnt(masm_, "[Load from global property");

Powered by Google App Engine
This is Rietveld 408576698