Issue 294019: Verify correctness of external string only if slow asserts are enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294019: Verify correctness of external string only if slow asserts are enabled. (Closed)

Created:
11 years, 2 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Verify correctness of external string only if slow asserts are enabled. Committed: http://code.google.com/p/v8/source/detail?r=3090

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/objects.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 2 months ago (2009-10-20 09:04:42 UTC) #2

LGTM, but is there still a problem with converting cons strings using ToCString?
 This method should not be this slow, so avoiding the call to it just targets
the symptoms, not the disease.  Does this have n^2 behavior?

Expand Messages | Collapse Messages