Issue 294005: gcl: Make fix the override_description code and add a silent flag....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294005: gcl: Make fix the override_description code and add a silent flag.... (Closed)

Created:
11 years, 2 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
laforge, M-A Ruel

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

gcl: Make fix the override_description code and add a silent flag. drover: switch to use optparse, and add the arguments to be able to support the revert bot.

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -66 lines)			Patch
	M	drover.py	View	1	6 chunks	+73 lines, -56 lines	0 comments	Download
	M	gcl.py	View		3 chunks	+13 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

updated the code with help strings and fix 80 chars lines. will TBR later today ...

11 years, 2 months ago (2009-10-18 19:24:26 UTC) #2

Both sets of code look fine to me.

Expand Messages | Collapse Messages