Add option to build googleurl as dll...

Add option to build googleurl as dll
-. Export/import google url APIs if GURL_DLL is defined.
-. Move DecodeURLEscapeSequences from webcore KURLGoogle
   to url_util to avoid external code accessing googleurl
   global varaibles.

R=brettw
BUG=46311
TEST=Googleurl_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138

[darin (slow to review), 2010-07-09 04:28:07]

I'm a little concerned about not decorating all "public" functions and methods
with GURL_API.  In the future, someone might add a dependency on one of the
undecorated functions, and that will then break the DLL build if they forget to
build it.

Since we don't really care about reducing the number of exported functions (as
this configuration is only for developer builds), how about just marking
everything with GURL_API?

[darin (slow to review), 2010-07-09 04:28:32]

Probably good to get Brett's take on my suggestion before investing the time to
make such a change.

[Victor Wang, 2010-07-09 04:54:40]

Brett, let me know your thoughts on this. This patch only exports those APIs
that are currently accessed from external code. I think Darin's suggestion on
exporting all public APIs is a good ideal to avoid future build break. Let me
know if I should go ahead to make the change.  
 
On 2010/07/09 04:28:32, darin wrote:
> Probably good to get Brett's take on my suggestion before investing the time
to
> make such a change.

[brettw, 2010-07-12 05:12:01]

I agree with Darin about having all public methods be exported. Otherwise I
think this is a good approach.

[Victor Wang, 2010-07-12 18:33:40]

On 2010/07/12 05:12:01, brettw wrote:
> I agree with Darin about having all public methods be exported. Otherwise I
> think this is a good approach.

New patch uploaded. Please take a look. Thanks!

[brettw, 2010-07-12 22:20:40]

LGTM, just one minor comment.

http://codereview.chromium.org/2939004/diff/13002/34006
File src/url_common.h (right):

http://codereview.chromium.org/2939004/diff/13002/34006#newcode30
src/url_common.h:30: #ifndef GOOGLEURL_SRC_URL_COMMON_H__
Use only one underscore at the end of include guards.

[Victor Wang, 2010-07-12 22:33:47]

http://codereview.chromium.org/2939004/diff/13002/34006
File src/url_common.h (right):

http://codereview.chromium.org/2939004/diff/13002/34006#newcode30
src/url_common.h:30: #ifndef GOOGLEURL_SRC_URL_COMMON_H__
On 2010/07/12 22:20:40, brettw wrote:
> Use only one underscore at the end of include guards.
Looks like other header files use two underscores at the end, do you think we
should make this one different? I know google c++ style guide says one
underscore, so another option would be changing the #define guard in all header
files to end with one underscore. I think we should make all files be consistent
regardless which option to follow...