Removed site_ui.xcommand and made md5_file ignore exceptions.

Removed site_ui.xcommand and made md5_file ignore exceptions.

[Tammo Spalink, 2010-07-14 16:02:05]

http://codereview.chromium.org/2938010/diff/1/2
File client/site_tests/graphics_GLBench/graphics_GLBench.py (right):

http://codereview.chromium.org/2938010/diff/1/2#newcode39
client/site_tests/graphics_GLBench/graphics_GLBench.py:39: 'DISPLAY=:0
XAUTHORITY=/home/chronos/.Xauthority ' + exefile +
sorry, it looks like I was not clear in my description of the issue -- the
factory process already sets up these environment variables (to values that are
different from these) and so it might be nice if you can maybe take an extra
argument to run_once, for example need_site_ui=True for example, and if that is
false, you run the command without site_ui and without setting any env vars.

[Alexey Marinichev, 2010-07-14 17:52:48]

http://codereview.chromium.org/2938010/diff/1/2
File client/site_tests/graphics_GLBench/graphics_GLBench.py (right):

http://codereview.chromium.org/2938010/diff/1/2#newcode39
client/site_tests/graphics_GLBench/graphics_GLBench.py:39: 'DISPLAY=:0
XAUTHORITY=/home/chronos/.Xauthority ' + exefile +
I still don't really understand how factory process runs these tests, sorry
about that.  It is easy to add need_site_ui parameter, but then where would that
be actually set?

The test itself actually spawns yet another X server, I was thinking that would
reduce the effects of other clients running on the existing one.  I could pack
the board id into the output of the test, then I wouldn't need an extra call for
that.

Would that resolve this issue?

On 2010/07/14 16:02:06, tammo wrote:
> sorry, it looks like I was not clear in my description of the issue -- the
> factory process already sets up these environment variables (to values that
are
> different from these) and so it might be nice if you can maybe take an extra
> argument to run_once, for example need_site_ui=True for example, and if that
is
> false, you run the command without site_ui and without setting any env vars.

[Alexey Marinichev, 2010-07-14 18:21:15]

This is the quickest way to get to the running state.

Meanwhile I'll try to cook up the fix I described in the previous comment.

[Alexey Marinichev, 2010-07-14 19:28:05]

Last change should work, just tested it.

[Tammo Spalink, 2010-07-14 20:53:35]

lgtm