Issue 2937001: Replace TlclDefineSpace with SafeDefineSpace for extra paranoia.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2937001: Replace TlclDefineSpace with SafeDefineSpace for extra paranoia. (Closed)

Created:
10 years, 5 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@chromiumos-git/vboot_reference.git

Visibility:
Public.

Replace TlclDefineSpace with SafeDefineSpace for extra paranoia.

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -20 lines)			Patch
M	firmware/lib/rollback_index.c	View	1 2 3	4 chunks	+21 lines, -6 lines	0 comments	Download
M	firmware/version.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/rollback_index_test.c	View		11 chunks	+33 lines, -13 lines	0 comments	Download

Total messages: 3 (0 generated)

Luigi Semenzato

It's unclear that this code will ever be useful, but it's more paranoid than before, ...

10 years, 5 months ago (2010-07-08 18:04:48 UTC) #1

lgtm