Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: chrome_frame/metrics_service.cc

Issue 2936005: Compress and checksum pending logs that are going to be persisted. ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/metrics_service.cc
===================================================================
--- chrome_frame/metrics_service.cc (revision 52082)
+++ chrome_frame/metrics_service.cc (working copy)
@@ -437,21 +437,20 @@
return false;
}
- pending_log_text_ = PrepareLogSubmissionString();
- DCHECK(!pending_log_text_.empty());
+ std::string pending_log_text = PrepareLogSubmissionString();
+ DCHECK(!pending_log_text.empty());
// Allow security conscious users to see all metrics logs that we send.
- LOG(INFO) << "METRICS LOG: " << pending_log_text_;
+ LOG(INFO) << "METRICS LOG: " << pending_log_text;
bool ret = true;
- std::string compressed_log;
- if (!Bzip2Compress(pending_log_text_, &compressed_log)) {
+ if (!Bzip2Compress(pending_log_text, &compressed_log_)) {
NOTREACHED() << "Failed to compress log for transmission.";
ret = false;
} else {
HRESULT hr = ChromeFrameMetricsDataUploader::UploadDataHelper(
- compressed_log);
+ compressed_log_);
DCHECK(SUCCEEDED(hr));
}
DiscardPendingLog();
« chrome/browser/metrics/metrics_service.h ('K') | « chrome/common/metrics_helpers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698