Prevent non-visible views from getting focused.

Prevent non-visible views from getting focused.

BUG=48719
TEST=FocusManagerTest.TraversalWithNonVisibleViews

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52293

[Mattias Nissler (ping if slow), 2010-07-12 14:53:55]

Scott, this fixes another problem of my recent TabbedPane CL. On windows, the
tab contents of invisible tabs are technically still part of the hierarchy, but
invisible, which is needed for proper sizing. This massages the focus code to
not focus invisible views.

[sky, 2010-07-12 15:31:30]

LGTM

[Paweł Hajdan Jr., 2010-07-13 03:20:47]

Drive-by with a tiny testing nit. No need to wait for another review by me.

http://codereview.chromium.org/2935005/diff/1/2
File views/focus/focus_manager_unittest.cc (right):

http://codereview.chromium.org/2935005/diff/1/2#newcode1170
views/focus/focus_manager_unittest.cc:1170: if (v)
nit: the above ASSERT makes this NULL-check redundant. Could you remove it, or
change the above to EXPECT if you meant that?

[Mattias Nissler (ping if slow), 2010-07-13 08:26:59]

http://codereview.chromium.org/2935005/diff/1/2
File views/focus/focus_manager_unittest.cc (right):

http://codereview.chromium.org/2935005/diff/1/2#newcode1170
views/focus/focus_manager_unittest.cc:1170: if (v)
On 2010/07/13 03:20:50, Paweł Hajdan Jr. wrote:
> nit: the above ASSERT makes this NULL-check redundant. Could you remove it, or
> change the above to EXPECT if you meant that?

Removing the conditional is the correct fix. I'll also change the test I copied
this section from :)