Issue 2934019: Upping the diagnostic mode limits for file size...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2934019: Upping the diagnostic mode limits for file size... (Closed)

Created:
10 years, 5 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
mattm

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Upping the diagnostic mode limits for file size - The local state and the overall size of the profile dir BUG=42561 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52400

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/diagnostics/recon_diagnostics.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mattm

On 2010/07/14 18:48:53, cpu wrote: > easy change. lgtm, though not sure about the Local ...

10 years, 5 months ago (2010-07-14 20:18:13 UTC) #2

cpu_(ooo_6.6-7.5)

10 years, 5 months ago (2010-07-14 20:53:35 UTC) #3

On 2010/07/14 20:18:13, mattm wrote:
> On 2010/07/14 18:48:53, cpu wrote:
> > easy change.
> 
> lgtm, though not sure about the Local State getting that big.  Mine are all
> under 10K.
> 
> Also, I wonder if it would be good to introduce a "warning" result type for
> tests like this that aren't necessarily a fail but could indicate issues.

Yeah, I've been thinking about warning level. I think we'll have to do that
after we get some other basic checks done.

For the local state there are cases of backlogged UMA data, like up to the last
3 sessions, that are not yet sent. Things that don't understand well.

Expand Messages | Collapse Messages