Issue 2934010: Add link to privacy dashboard from sync options panel behind command line fla...

Issue 2934010: Add link to privacy dashboard from sync options panel behind command line fla... (Closed)

Created:
10 years, 5 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
John Gregg, laforge

CC:
chromium-reviews, finnur+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add link to privacy dashboard from sync options panel behind command line flag. BUG=48844 TEST=Open options > Personal Stuff, see link to dashboard. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52112

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -3 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/app/resources/locale_settings.grd	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/options/content_page_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/options/content_page_view.cc	View	1 2	4 chunks	+23 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

Hi John & Anthony, I'm adding this link behind a flag as we won't be ...

10 years, 5 months ago (2010-07-12 17:38:30 UTC) #1

John Gregg

LGTM with 1 nit. http://codereview.chromium.org/2934010/diff/6001/7005 File chrome/browser/views/options/content_page_view.cc (right): http://codereview.chromium.org/2934010/diff/6001/7005#newcode177 chrome/browser/views/options/content_page_view.cc:177: return; style nit: because if ...

10 years, 5 months ago (2010-07-12 17:55:48 UTC) #2

tim (not reviewing)

10 years, 5 months ago (2010-07-12 18:00:27 UTC) #3

http://codereview.chromium.org/2934010/diff/6001/7005
File chrome/browser/views/options/content_page_view.cc (right):

http://codereview.chromium.org/2934010/diff/6001/7005#newcode177
chrome/browser/views/options/content_page_view.cc:177: return;
On 2010/07/12 17:55:49, John Gregg wrote:
> style nit: because if the early returns I think you should drop the "else"s.

Done.

Expand Messages | Collapse Messages