Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2932009: Mac: Tweak content settings window. (Closed)

Created:
10 years, 5 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Mac: Tweak content settings window. Add "Features" label to source list. xib change: Add some vertical space at the top of each tab, change outline view cell size to "small", hook up new outlet. http://i.imgur.com/KGES6.png BUG=45546 TEST=Content settings window still works: Current pane is still remembered, and opening the window from a bubble selects the right pane. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52199

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : no triangle, control size "small" #

Patch Set 4 : cleanups & tests #

Total comments: 22

Patch Set 5 : comments #

Patch Set 6 : sigh #

Total comments: 4

Patch Set 7 : ... #

Patch Set 8 : fffffffffffffffff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -73 lines) Patch
M base/cocoa_protocols_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/nibs/ContentSettings.xib View 1 2 3 41 chunks +64 lines, -47 lines 0 comments Download
M chrome/browser/cocoa/content_settings_dialog_controller.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/content_settings_dialog_controller.mm View 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/tab_view_picker_table.h View 1 2 3 4 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/tab_view_picker_table.mm View 1 2 3 4 5 6 7 4 chunks +112 lines, -17 lines 0 comments Download
M chrome/browser/cocoa/tab_view_picker_table_unittest.mm View 2 chunks +25 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nico
i hate this dialog
10 years, 5 months ago (2010-07-12 22:58:30 UTC) #1
viettrungluu
For some reason, I didn't get email for the "I hate this dialog.". http://codereview.chromium.org/2932009/diff/6001/7005 File ...
10 years, 5 months ago (2010-07-13 03:14:10 UTC) #2
Robert Sesek
http://codereview.chromium.org/2932009/diff/6001/7006 File chrome/browser/cocoa/tab_view_picker_table.mm (right): http://codereview.chromium.org/2932009/diff/6001/7006#newcode9 chrome/browser/cocoa/tab_view_picker_table.mm:9: @interface TabViewPickerTable(Private) Space between class name and category. I've ...
10 years, 5 months ago (2010-07-13 14:58:10 UTC) #3
viettrungluu
http://codereview.chromium.org/2932009/diff/6001/7006 File chrome/browser/cocoa/tab_view_picker_table.mm (right): http://codereview.chromium.org/2932009/diff/6001/7006#newcode9 chrome/browser/cocoa/tab_view_picker_table.mm:9: @interface TabViewPickerTable(Private) On 2010/07/13 14:58:10, rsesek wrote: > Space ...
10 years, 5 months ago (2010-07-13 15:08:50 UTC) #4
Nico
Thanks! http://codereview.chromium.org/2932009/diff/6001/7005 File chrome/browser/cocoa/tab_view_picker_table.h (right): http://codereview.chromium.org/2932009/diff/6001/7005#newcode10 chrome/browser/cocoa/tab_view_picker_table.h:10: // TabViewPickerTable is an NSTableView that can be ...
10 years, 5 months ago (2010-07-13 16:59:40 UTC) #5
viettrungluu
http://codereview.chromium.org/2932009/diff/6001/7006 File chrome/browser/cocoa/tab_view_picker_table.mm (right): http://codereview.chromium.org/2932009/diff/6001/7006#newcode126 chrome/browser/cocoa/tab_view_picker_table.mm:126: if (!item) On 2010/07/13 16:59:40, Nico wrote: > On ...
10 years, 5 months ago (2010-07-13 17:29:31 UTC) #6
Nico
*shrug* done On Tue, Jul 13, 2010 at 10:29 AM, <viettrungluu@chromium.org> wrote: > > http://codereview.chromium.org/2932009/diff/6001/7006 ...
10 years, 5 months ago (2010-07-13 17:43:18 UTC) #7
Nico
ping
10 years, 5 months ago (2010-07-13 18:15:38 UTC) #8
Robert Sesek
http://codereview.chromium.org/2932009/diff/17001/18006 File chrome/browser/cocoa/tab_view_picker_table.mm (right): http://codereview.chromium.org/2932009/diff/17001/18006#newcode124 chrome/browser/cocoa/tab_view_picker_table.mm:124: return tabIndex; DCHECK(tabIndex < [self numberOfTabViewItems])? http://codereview.chromium.org/2932009/diff/17001/18006#newcode149 chrome/browser/cocoa/tab_view_picker_table.mm:149: heading_.get() ...
10 years, 5 months ago (2010-07-13 18:25:41 UTC) #9
Nico
You guys are seriously overthinking this. http://codereview.chromium.org/2932009/diff/6001/7006 File chrome/browser/cocoa/tab_view_picker_table.mm (right): http://codereview.chromium.org/2932009/diff/6001/7006#newcode68 chrome/browser/cocoa/tab_view_picker_table.mm:68: if (heading_) On ...
10 years, 5 months ago (2010-07-13 18:40:17 UTC) #10
Robert Sesek
On 2010/07/13 18:40:17, Nico wrote: > You guys are seriously overthinking this. :D LGTM
10 years, 5 months ago (2010-07-13 18:45:19 UTC) #11
viettrungluu
10 years, 5 months ago (2010-07-13 18:57:36 UTC) #12
On 2010/07/13 18:40:17, Nico wrote:
> You guys are seriously overthinking this.

Nah, it's just (International) Pick-on-Thakis Day. ;-)

LGTM.

Powered by Google App Engine
This is Rietveld 408576698