Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2932007: Use WebCore's built in support for user styles (Closed)

Created:
10 years, 5 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Use WebCore's built in support for user styles instead of the hack we were doing before. This has a side-effect of fixing a bunch of content-interaction bugs because we will be using real user-level styles (in the CSS sense) rather than content-level styles. BUG=29995 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52581 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52584

Patch Set 1 #

Patch Set 2 : comments #

Total comments: 2

Patch Set 3 : whoops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -17 lines) Patch
M chrome/common/extensions/url_pattern.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/common/extensions/url_pattern.cc View 1 2 3 chunks +29 lines, -7 lines 0 comments Download
M chrome/common/extensions/url_pattern_unittest.cc View 11 chunks +40 lines, -0 lines 0 comments Download
M chrome/renderer/user_script_slave.cc View 1 3 chunks +45 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Aaron Boodman
10 years, 5 months ago (2010-07-09 23:24:08 UTC) #1
Erik does not do reviews
woot On Fri, Jul 9, 2010 at 4:24 PM, <aa@chromium.org> wrote: > Reviewers: Matt Perry, ...
10 years, 5 months ago (2010-07-09 23:31:57 UTC) #2
Matt Perry
10 years, 5 months ago (2010-07-09 23:32:43 UTC) #3
lgtm with small issues fixed

http://codereview.chromium.org/2932007/diff/2001/3002
File chrome/common/extensions/url_pattern.h (right):

http://codereview.chromium.org/2932007/diff/2001/3002#newcode163
chrome/common/extensions/url_pattern.h:163: // Conver this URLPattern into an
equivalent set of URLPatterns that don't use
convert

http://codereview.chromium.org/2932007/diff/2001/3004
File chrome/renderer/user_script_slave.cc (right):

http://codereview.chromium.org/2932007/diff/2001/3004#newcode166
chrome/renderer/user_script_slave.cc:166: script->match_all_frames() ?
indent

Powered by Google App Engine
This is Rietveld 408576698