Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2931016: Remove check for heap allocated locals from code flushing.... (Closed)

Created:
10 years, 5 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Remove check for heap allocated locals from code flushing. Since bleeding edge revision 5056 we no longer need to check that there are no heap allocated locals in the scope info, since these will be preserved after the scope info was moved to the SharedFunctionInfo class. Committed: http://code.google.com/p/v8/source/detail?r=5066

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/heap.cc View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
10 years, 5 months ago (2010-07-14 06:58:45 UTC) #1
Kasper Lund
LGTM. http://codereview.chromium.org/2931016/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/2931016/diff/1/2#newcode2484 src/heap.cc:2484: // Compute the lazy compilable version of the ...
10 years, 5 months ago (2010-07-14 07:00:30 UTC) #2
Rico
10 years, 5 months ago (2010-07-14 07:10:44 UTC) #3
http://codereview.chromium.org/2931016/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/2931016/diff/1/2#newcode2484
src/heap.cc:2484: // Compute the lazy compilable version of the code, clear the
scope info.
On 2010/07/14 07:00:30, Kasper Lund wrote:
> Update comment (scope info isn't cleared). Maybe move the comment above the
> HandleScope declaration. That looks better to me.

Done.

Powered by Google App Engine
This is Rietveld 408576698