Implementing better fallback algorithm....

Implementing better fallback algorithm.

Before:
 current_locale->default_locale

Now:
 current_locale->chain_of_parent_locales->default_locale

If default_locale is de, and current locale en_US, we follow:
en_US -> en -> de

en is not a Chrome locale (only en_US, en_GB are), but we fake it to allow this kind of fallback.

Developers can implement common locale root with most of the messages (like en) and put locale specifics in en_GB (color->colour) or en_US. You can even symlink en and en_US and save on work.

I am planning on fixing loading local resources too, to use this child->parent fallback.

BUG=12131
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29684

[Aaron Boodman, 2009-10-20 23:52:56]

http://codereview.chromium.org/293037/diff/1/7
File chrome/common/extensions/extension_message_bundle.cc (right):

http://codereview.chromium.org/293037/diff/1/7#newcode39
Line 39: const std::vector<linked_ptr<DictionaryValue> >& locale_catalogs,
It would be nice to add a typedef for this vector.

http://codereview.chromium.org/293037/diff/1/7#newcode54
Line 54: for (size_t i = 0; i < locale_catalogs.size(); ++i) {
This could be implemented with less code by looping in reverse order and
overwriting entries from more general catalogs with entries from more specific
ones.

http://codereview.chromium.org/293037/diff/1/8
File chrome/common/extensions/extension_message_bundle.h (right):

http://codereview.chromium.org/293037/diff/1/8#newcode38
Line 38: const std::vector<linked_ptr<DictionaryValue> >& locale_catalogs,
You should note in the comment what order the catalogs are expected in (most to
least specific, or the reverse).

[Nebojša Ćirić, 2009-10-21 00:21:51]

All done.

It's somewhat debatable if there is a much less code if I do it in reverse (one
line maybe, with more data writes), but it's ok either way.

On 2009/10/20 23:52:56, Aaron Boodman wrote:
> http://codereview.chromium.org/293037/diff/1/7
> File chrome/common/extensions/extension_message_bundle.cc (right):
> 
> http://codereview.chromium.org/293037/diff/1/7#newcode39
> Line 39: const std::vector<linked_ptr<DictionaryValue> >& locale_catalogs,
> It would be nice to add a typedef for this vector.
> 
> http://codereview.chromium.org/293037/diff/1/7#newcode54
> Line 54: for (size_t i = 0; i < locale_catalogs.size(); ++i) {
> This could be implemented with less code by looping in reverse order and
> overwriting entries from more general catalogs with entries from more specific
> ones.
> 
> http://codereview.chromium.org/293037/diff/1/8
> File chrome/common/extensions/extension_message_bundle.h (right):
> 
> http://codereview.chromium.org/293037/diff/1/8#newcode38
> Line 38: const std::vector<linked_ptr<DictionaryValue> >& locale_catalogs,
> You should note in the comment what order the catalogs are expected in (most
to
> least specific, or the reverse).

[Aaron Boodman, 2009-10-21 19:06:19]

lgtm