Use WriteToFlat instead of to C strings methods as WriteToFlat performs notab...

Use WriteToFlat instead of to C strings methods as WriteToFlat performs notably
better for various kinds of strings.

[antonm, 2009-10-20 16:19:24]

Erik, William,

yes, I promised to fix ToCStrings methods, but having a closer look to those
noticed that logic is not quite simple, e.g. treatment of embedded 0, probably
UTF8 conversions (yes, ascii should be UTF8 and two bytes strings probably
should be UTF16).  And there is an explicit warning for those methods, so I
decided not to do a fast case (if destination and the string are of the same
kind, WriteToFlat), nor to flatten strings, but instead fixed two nasty callers
(keeping with contract of to C string methods).

Do you think it reasonable?  If not, would you mind if I just flatten strings in
to C string (depending on RobustFlag).

[Erik Corry, 2009-10-20 18:22:43]

This LGTM but I still thing we should fix ToCString, probably not by flattening.

[William Hesse, 2009-10-21 07:51:10]

LGTM.  Should ToCString be assigned a new bug as long as it has n^2 behavior?