base/process_util_unittest.cc - Issue 293018: Fix ProcessUtilTest.FDRemapping hang on x86_64 by counting open fds in child ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process_util_unittest.cc

Issue 293018: Fix ProcessUtilTest.FDRemapping hang on x86_64 by counting open fds in child ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process_util_unittest.cc

===================================================================

--- base/process_util_unittest.cc (revision 29472)

+++ base/process_util_unittest.cc (working copy)

@@ -198,7 +198,9 @@

int max_files = GetMaxFilesOpenInProcess();

for (int i = STDERR_FILENO + 1; i < max_files; i++) {

if (i != kChildPipe) {

- if (HANDLE_EINTR(close(i)) != -1) {

+ int fd;

+ if ((fd = HANDLE_EINTR(dup(i))) != -1) {

+ close(fd);

num_open_files += 1;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »