Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 293001: Delete glue/webview{_delegate}.h (Closed)

Created:
11 years, 2 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Delete glue/webview{_delegate}.h R=dglazkov BUG=10033 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29390

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -296 lines) Patch
M chrome/common/render_messages.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/devtools_agent.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/bindings_utils.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/external_extension.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/print_web_view_helper.h View 1 2 8 chunks +7 lines, -9 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 2 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.h View 1 2 8 chunks +10 lines, -9 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/render_view_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/api/public/WebFrame.h View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M webkit/api/public/WebView.h View 1 2 2 chunks +15 lines, -7 lines 0 comments Download
M webkit/api/public/WebViewClient.h View 1 2 3 chunks +3 lines, -11 lines 0 comments Download
M webkit/glue/back_forward_list_client_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 2 2 chunks +19 lines, -21 lines 0 comments Download
M webkit/glue/context_menu_client_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/context_menu_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/cpp_bound_class_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/dom_operations.h View 1 2 5 chunks +13 lines, -10 lines 0 comments Download
M webkit/glue/dom_operations.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/dom_operations_private.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/dom_operations_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/dom_serializer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/dragclient_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/editor_client_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/iframe_redirect_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/inspector_client_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/mimetype_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/resource_fetcher_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webaccessibilitymanager.h View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M webkit/glue/webaccessibilitymanager_impl.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/webaccessibilitymanager_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webdevtoolsclient.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webdevtoolsclient_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webframe_impl.h View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webframe_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webframe_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webframeloaderclient_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webframeloaderclient_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkit_glue.h View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/webplugin_impl.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
D webkit/glue/webview.h View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/glue/webview_delegate.h View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
M webkit/glue/webview_impl.h View 1 2 7 chunks +11 lines, -17 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 2 12 chunks +35 lines, -30 lines 0 comments Download
M webkit/glue/webview_unittest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/webworker_impl.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/glue/webworker_impl.cc View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/drag_delegate.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/drag_delegate.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/drop_delegate.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/drop_delegate.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/event_sending_controller.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/event_sending_controller.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mac/test_shell_webview.mm View 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mac/test_webview_delegate.mm View 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mac/webview_host.mm View 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/plugin_tests.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 3 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/text_input_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webview_host.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/webview_host_gtk.cc View 2 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/webview_host_win.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/webkit.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 2 months ago (2009-10-17 07:13:14 UTC) #1
dglazkov
11 years, 2 months ago (2009-10-17 16:06:37 UTC) #2 
LGTM once you take care of that Mac compile failure on the trybot.

This CL... makes me feel like this: http://www.youtube.com/watch?v=DhlPAj38rHc

Powered by Google App Engine
This is Rietveld 408576698