Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9687)

Unified Diff: chrome/common/pref_member.h

Issue 2929: Some initial work on compiling chrome/common/ on Linux.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/libxml_utils.cc ('k') | chrome/common/slide_animation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/pref_member.h
===================================================================
--- chrome/common/pref_member.h (revision 2299)
+++ chrome/common/pref_member.h (working copy)
@@ -53,14 +53,15 @@
const std::wstring& pref_name() const { return pref_name_; }
PrefService* prefs() { return prefs_; }
+ // Ordered the members to compact the class instance.
+ private:
+ std::wstring pref_name_;
+ NotificationObserver* observer_;
+ PrefService* prefs_;
+
protected:
bool is_synced_;
bool setting_value_;
-
- private:
- std::wstring pref_name_;
- PrefService* prefs_;
- NotificationObserver* observer_;
};
} // namespace subtle
@@ -120,7 +121,7 @@
class BooleanPrefMember : public PrefMember<bool> {
public:
- BooleanPrefMember() : PrefMember() { }
+ BooleanPrefMember() : PrefMember<bool>() { }
virtual ~BooleanPrefMember() { }
protected:
@@ -133,7 +134,7 @@
class IntegerPrefMember : public PrefMember<int> {
public:
- IntegerPrefMember() : PrefMember() { }
+ IntegerPrefMember() : PrefMember<int>() { }
virtual ~IntegerPrefMember() { }
protected:
@@ -146,7 +147,7 @@
class RealPrefMember : public PrefMember<double> {
public:
- RealPrefMember() : PrefMember() { }
+ RealPrefMember() : PrefMember<double>() { }
virtual ~RealPrefMember() { }
protected:
@@ -159,7 +160,7 @@
class StringPrefMember : public PrefMember<std::wstring> {
public:
- StringPrefMember() : PrefMember() { }
+ StringPrefMember() : PrefMember<std::wstring>() { }
virtual ~StringPrefMember() { }
protected:
« no previous file with comments | « chrome/common/libxml_utils.cc ('k') | chrome/common/slide_animation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698