Retrieve favicons from history as NavigationEntries are converted from TabNav...

ui/base/models/menu_model.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_MODELS_MENU_MODEL_H_
 #define UI_BASE_MODELS_MENU_MODEL_H_
 #pragma once
 
 #include "base/scoped_ptr.h"
 #include "base/string16.h"
@@ skipping 18 matching lines @@
     TYPE_COMMAND,
     TYPE_CHECK,
     TYPE_RADIO,
     TYPE_SEPARATOR,
     TYPE_BUTTON_ITEM,
     TYPE_SUBMENU
   };
 
   virtual ~MenuModel() {}
 
+  class Delegate {

[sky, 2011/02/22 18:28:28]

Move this into its own file and call it MenuModelDelegate. We've been going with
this rather than inlining to avoid extra includes.

[dill, 2011/02/24 15:00:28]

This should go in ui\base\models, correct?

On 2011/02/22 18:28:28, sky wrote:

[sky, 2011/02/24 15:12:50]

yes.

+   public:
+    // Invoked when an icon has been loaded from history.
+    virtual void OnIconChanged(int index) {}
+   protected:
+    virtual ~Delegate() {}
+  };
+
   // Returns true if any of the items within the model have icons. Not all
   // platforms support icons in menus natively and so this is a hint for
   // triggering a custom rendering mode.
   virtual bool HasIcons() const = 0;
 
   // Returns the index of the first item. This is 0 for most menus except the
   // system menu on Windows. |native_menu| is the menu to locate the start index
   // within. It is guaranteed to be reset to a clean default state.
   // IMPORTANT: If the model implementation returns something _other_ than 0
   //            here, it must offset the values for |index| it passes to the
@@ skipping 29 matching lines @@
 
   // Returns the checked state of the item at the specified index.
   virtual bool IsItemCheckedAt(int index) const = 0;
 
   // Returns the id of the group of radio items that the item at the specified
   // index belongs to.
   virtual int GetGroupIdAt(int index) const = 0;
 
   // Gets the icon for the item at the specified index, returning true if there
   // is an icon, false otherwise.
-  virtual bool GetIconAt(int index, SkBitmap* icon) const = 0;
+  virtual bool GetIconAt(int index, SkBitmap* icon) = 0;
 
   // Returns the model for a menu item with a line of buttons at |index|.
   virtual ButtonMenuItemModel* GetButtonMenuItemAt(int index) const = 0;
 
   // Returns the enabled state of the item at the specified index.
   virtual bool IsEnabledAt(int index) const = 0;
 
   // Returns true if the menu item is visible.
   virtual bool IsVisibleAt(int index) const;
 
@@ skipping 10 matching lines @@
   // Called when the item has been activated with a given disposition (for the
   // case where the activation involves a navigation).
   virtual void ActivatedAtWithDisposition(int index, int disposition);
 
   // Called when the menu is about to be shown.
   virtual void MenuWillShow() {}
 
   // Called when the menu has been closed.
   virtual void MenuClosed() {}
 
+  // Set the Delegate

[sky, 2011/02/22 18:28:28]

End with period, and mention not-owned.

+  virtual void SetDelegate(Delegate* delegate) = 0;
+
   // Retrieves the model and index that contains a specific command id. Returns
   // true if an item with the specified command id is found. |model| is inout,
   // and specifies the model to start searching from.
   static bool GetModelAndIndexForCommandId(int command_id, MenuModel** model,
                                            int* index);
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_MODELS_MENU_MODEL_H_