Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2927014: Merge 62134 - <rdar://problem/7975842> Certain text is repeated after using s... (Closed)

Created:
10 years, 5 months ago by Cris Neckar
Modified:
9 years, 7 months ago
Reviewers:
Cris Neckar
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 62134 - <rdar://problem/7975842> Certain text is repeated after using splitText() Reviewed by Darin Adler. WebCore: Tests: fast/text/setData-dirty-lines.html fast/text/splitText-dirty-lines.html * dom/CharacterData.cpp: (WebCore::CharacterData::setData): Call RenderText::setTextWithOffset() rather than setText(), because only the former correctly dirties line boxes. * dom/Text.cpp: (WebCore::Text::splitText): Ditto. LayoutTests: * fast/text/setData-dirty-lines-expected.checksum: Added. * fast/text/setData-dirty-lines-expected.png: Added. * fast/text/setData-dirty-lines-expected.txt: Added. * fast/text/setData-dirty-lines.html: Added. * fast/text/splitText-dirty-lines-expected.checksum: Added. * fast/text/splitText-dirty-lines-expected.png: Added. * fast/text/splitText-dirty-lines-expected.txt: Added. * fast/text/splitText-dirty-lines.html: Added. BUG=42736 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -5 lines) Patch
A LayoutTests/fast/text/setData-dirty-lines.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/setData-dirty-lines-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/text/setData-dirty-lines-expected.png View Binary file 0 comments Download
A LayoutTests/fast/text/setData-dirty-lines-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/splitText-dirty-lines.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/splitText-dirty-lines-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/text/splitText-dirty-lines-expected.png View Binary file 0 comments Download
A LayoutTests/fast/text/splitText-dirty-lines-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
M WebCore/dom/CharacterData.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M WebCore/dom/Text.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Cris Neckar
10 years, 5 months ago (2010-07-14 18:59:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698