Issue 2927004: Hookup Pepper v2 GetSelectedText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2927004: Hookup Pepper v2 GetSelectedText. (Closed)

Created:
10 years, 5 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Hookup Pepper v2 GetSelectedText. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51936

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/glue/plugins/pepper_plugin_instance.cc	View	1	3 chunks	+7 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

http://codereview.chromium.org/2927004/diff/8001/9002 File webkit/glue/plugins/pepper_plugin_instance.cc (right): http://codereview.chromium.org/2927004/diff/8001/9002#newcode344 webkit/glue/plugins/pepper_plugin_instance.cc:344: return string16(UTF8ToUTF16(string->value())); UTF8ToUTF16 already returns string16, so it should ...

10 years, 5 months ago (2010-07-09 07:24:52 UTC) #3

jam

10 years, 5 months ago (2010-07-09 07:29:27 UTC) #4

thanks, that was leftover from previous code.  committed in a followpu

On Fri, Jul 9, 2010 at 12:24 AM, <darin@chromium.org> wrote:

>
> http://codereview.chromium.org/2927004/diff/8001/9002
> File webkit/glue/plugins/pepper_plugin_instance.cc (right):
>
> http://codereview.chromium.org/2927004/diff/8001/9002#newcode344
> webkit/glue/plugins/pepper_plugin_instance.cc:344: return
> string16(UTF8ToUTF16(string->value()));
> UTF8ToUTF16 already returns string16, so it should not be necessary to
> construct another copy of that.
>
>
> http://codereview.chromium.org/2927004/show
>

Expand Messages | Collapse Messages

Issue 2927004: Hookup Pepper v2 GetSelectedText. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages