Issue 2925011: Add a script for standalone signing of Chrome OS images.

Issue 2925011: Add a script for standalone signing of Chrome OS images. (Closed)

Created:
10 years, 5 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, vb

CC:
chromium-os-reviews_chromium.org, Randall Spangler, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Visibility:
Public.

Description

Add a script for standalone signing of Chrome OS images. Also created a new directory in the vboot_reference source where all signing scripts and related miscellanea will go.

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -1 line)			Patch
	M	firmware/version.c	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	scripts/image_signing/cros_resign_image_standalone.sh	View		1 chunk	+59 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

http://codereview.chromium.org/2925011/diff/1/3 File scripts/image_signing/cros_resign_image_standalone.sh (right): http://codereview.chromium.org/2925011/diff/1/3#newcode11 scripts/image_signing/cros_resign_image_standalone.sh:11: this script is oblivious to any of the errors ...

10 years, 5 months ago (2010-07-14 19:20:29 UTC) #4

gauravsh

10 years, 5 months ago (2010-07-14 20:42:54 UTC) #5

You are right. Sending you a separate CL with these fixes.

On 2010/07/14 19:20:29, vb wrote:
> http://codereview.chromium.org/2925011/diff/1/3
> File scripts/image_signing/cros_resign_image_standalone.sh (right):
> 
> http://codereview.chromium.org/2925011/diff/1/3#newcode11
> scripts/image_signing/cros_resign_image_standalone.sh:11: 
> this script is oblivious to any of the errors which might happen while
> executing. Maybe add `set -e' at the top at least?
> 
> http://codereview.chromium.org/2925011/diff/1/3#newcode58
> scripts/image_signing/cros_resign_image_standalone.sh:58: rm -f ${temp_kimage}
> aren't these taken care of by the traps in lines 36 and 38?

Expand Messages | Collapse Messages