Handle birthday errors by disabling sync and deleting sync data.

Handle birthday errors by disabling sync and deleting sync data. Also added some CV broadcasts in SyncerThread, as changing vault_ fields and not signalling seems dubious (and I caught a hang in the debugger where the thread was waiting for an already true condition, thus deadlocked).

BUG=46807, 39070
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52259

[tim (not reviewing), 2010-07-13 18:15:58]

Steve, please review SyncerThread changes
Chron, please look at the syncer proto util stuff and the path up to profile
sync service

Raz, FYI. Let me know when I can grab the new .proto with the new errorcode.

[chron_chromium.org, 2010-07-13 18:54:52]

http://codereview.chromium.org/2923006/diff/28001/29003
File chrome/browser/sync/engine/syncapi.h (right):

http://codereview.chromium.org/2923006/diff/28001/29003#newcode666
chrome/browser/sync/engine/syncapi.h:666: // be disabled and state cleaned up at
once.
You may wish to clarify that this is for clear private data or it could be
confused for throttling.

http://codereview.chromium.org/2923006/diff/28001/29005
File chrome/browser/sync/engine/syncer_thread.cc (right):

http://codereview.chromium.org/2923006/diff/28001/29005#newcode241
chrome/browser/sync/engine/syncer_thread.cc:241:
RequestSyncerExitAndSetThreadStopConditions();
Can you leave a comment on when this thread will terminate? Or whether it will
restart? The other invocation does thread_.stop(), it would be nice to know the
expected future lifetime of this thread after this call.

http://codereview.chromium.org/2923006/diff/28001/29014
File chrome/browser/sync/sessions/sync_session.h (right):

http://codereview.chromium.org/2923006/diff/28001/29014#newcode70
chrome/browser/sync/sessions/sync_session.h:70: // is a different instance
altogether (e.g. swapping from a test instance
This seems like the proper comment to use in previous places. Or some
abbreviated version.

[tim (not reviewing), 2010-07-13 23:50:39]

done!

[chron_chromium.org, 2010-07-13 23:53:25]

LGTM

On Tue, Jul 13, 2010 at 4:50 PM, <tim@chromium.org> wrote:

> done!
>
>
> http://codereview.chromium.org/2923006/show
>