Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2923005: Add testing for a solution entry where url = None. (Closed)

Created:
10 years, 5 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Add testing for a solution entry where url = None. This is being abused by WebKit. TEST=new smoke test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52096

Patch Set 1 #

Patch Set 2 : Add revinfo testing and corresponding fix #

Patch Set 3 : Add more testing #

Patch Set 4 : don't mention webkit as it's even weirder and I'll send another review for that #

Patch Set 5 : merged with HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M gclient.py View 2 3 4 4 chunks +13 lines, -10 lines 0 comments Download
M tests/gclient_smoketest.py View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 5 months ago (2010-07-11 22:38:52 UTC) #1
tony
10 years, 5 months ago (2010-07-12 17:28:10 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698