Changed the revision number of libjingle to r24.

Changed the revision number of libjingle to r24.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52089

[asharif1, 2010-07-09 18:51:15]

I don't know why the linux build for ChromeBrowser is failing. 

At least for ChromeOS, r24 seems to be compiling just fine. I think ChromeOS
doesn't build the tests that are failing for ChromeBrowser.

LGTM and commit this change because I don't have commit rights.

[asharif1, 2010-07-09 19:20:51]

On 2010/07/09 18:51:15, asharif1 wrote:
> I don't know why the linux build for ChromeBrowser is failing. 
> 
> At least for ChromeOS, r24 seems to be compiling just fine. I think ChromeOS
> doesn't build the tests that are failing for ChromeBrowser.
> 
> LGTM and commit this change because I don't have commit rights.

Nevermind, it also produces a linker error just like the trybot for
ChromeBrowser. 

Pthatcher, can you take a look at this?

[asharif1, 2010-07-09 19:40:58]

On 2010/07/09 19:20:51, asharif1 wrote:
> On 2010/07/09 18:51:15, asharif1 wrote:
> > I don't know why the linux build for ChromeBrowser is failing. 
> > 
> > At least for ChromeOS, r24 seems to be compiling just fine. I think ChromeOS
> > doesn't build the tests that are failing for ChromeBrowser.
> > 
> > LGTM and commit this change because I don't have commit rights.
> 
> Nevermind, it also produces a linker error just like the trybot for
> ChromeBrowser. 
> 
> Pthatcher, can you take a look at this?

Okay, it seems like the GYP file in libjingle does not contain the
sessionmessages.cc file which means it will not get compiled. 

So at link time the linker cannot find the definitions for the functions in that
file. 

How can I update the gyp file in libjingle? (I believe adding
sessionmessages.cc/h might fix this issue).

[pthatcher, 2010-07-09 19:48:19]

I don't know how to change GYP files, but you should know that you'll have
to add p2p/base/sessionmessages.cc and p2p/base/parsing.cc (with .h files).

Also, I'm going to cc Fred Akalin and Sergey Ulanov.  They have experience
using libjingle, and might be able to help you more than me.  Also, Sergey
has commit rights to code.google.com/p/libjingle.


By the way, sorry that the latest code broke your build at this inopportune
moment.  I hope we can get it fixed quickly.


On Fri, Jul 9, 2010 at 12:40 PM, <asharif@chromium.org> wrote:

> On 2010/07/09 19:20:51, asharif1 wrote:
>
>> On 2010/07/09 18:51:15, asharif1 wrote:
>> > I don't know why the linux build for ChromeBrowser is failing.
>> >
>> > At least for ChromeOS, r24 seems to be compiling just fine. I think
>> ChromeOS
>> > doesn't build the tests that are failing for ChromeBrowser.
>> >
>> > LGTM and commit this change because I don't have commit rights.
>>
>
>  Nevermind, it also produces a linker error just like the trybot for
>> ChromeBrowser.
>>
>
>  Pthatcher, can you take a look at this?
>>
>
> Okay, it seems like the GYP file in libjingle does not contain the
> sessionmessages.cc file which means it will not get compiled.
>
> So at link time the linker cannot find the definitions for the functions in
> that
> file.
>
> How can I update the gyp file in libjingle? (I believe adding
> sessionmessages.cc/h might fix this issue).
>
>
> http://codereview.chromium.org/2921004/show
>

[akalin, 2010-07-09 19:57:52]

You should just be able to edit the .gyp file like any other chrome file.  Just
add sessionmessages.{h,cc} and parsing.{h,cc} in the right place and you'll be
fine.

On 2010/07/09 19:48:19, pthatcher_google.com wrote:
> I don't know how to change GYP files, but you should know that you'll have
> to add p2p/base/sessionmessages.cc and p2p/base/parsing.cc (with .h files).
> 
> Also, I'm going to cc Fred Akalin and Sergey Ulanov.  They have experience
> using libjingle, and might be able to help you more than me.  Also, Sergey
> has commit rights to code.google.com/p/libjingle.
> 
> 
> By the way, sorry that the latest code broke your build at this inopportune
> moment.  I hope we can get it fixed quickly.
> 
> 
> On Fri, Jul 9, 2010 at 12:40 PM, <mailto:asharif@chromium.org> wrote:
> 
> > On 2010/07/09 19:20:51, asharif1 wrote:
> >
> >> On 2010/07/09 18:51:15, asharif1 wrote:
> >> > I don't know why the linux build for ChromeBrowser is failing.
> >> >
> >> > At least for ChromeOS, r24 seems to be compiling just fine. I think
> >> ChromeOS
> >> > doesn't build the tests that are failing for ChromeBrowser.
> >> >
> >> > LGTM and commit this change because I don't have commit rights.
> >>
> >
> >  Nevermind, it also produces a linker error just like the trybot for
> >> ChromeBrowser.
> >>
> >
> >  Pthatcher, can you take a look at this?
> >>
> >
> > Okay, it seems like the GYP file in libjingle does not contain the
> > sessionmessages.cc file which means it will not get compiled.
> >
> > So at link time the linker cannot find the definitions for the functions in
> > that
> > file.
> >
> > How can I update the gyp file in libjingle? (I believe adding
> > sessionmessages.cc/h might fix this issue).
> >
> >
> > http://codereview.chromium.org/2921004/show
> >
>

[asharif1, 2010-07-09 20:00:03]

Okay, that seems easy enough.

Should I make a CL on codereview.chromium.org so you or Sergey can commit?

I don't have commit rights.

On Fri, Jul 9, 2010 at 12:57 PM, <akalin@chromium.org> wrote:

> You should just be able to edit the .gyp file like any other chrome file.
>  Just
> add sessionmessages.{h,cc} and parsing.{h,cc} in the right place and you'll
> be
> fine.
>
>
> On 2010/07/09 19:48:19, pthatcher_google.com wrote:
>
>> I don't know how to change GYP files, but you should know that you'll have
>> to add p2p/base/sessionmessages.cc and p2p/base/parsing.cc (with .h
>> files).
>>
>
>  Also, I'm going to cc Fred Akalin and Sergey Ulanov.  They have experience
>> using libjingle, and might be able to help you more than me.  Also, Sergey
>> has commit rights to code.google.com/p/libjingle.
>>
>
>
>  By the way, sorry that the latest code broke your build at this
>> inopportune
>> moment.  I hope we can get it fixed quickly.
>>
>
>
>  On Fri, Jul 9, 2010 at 12:40 PM, <mailto:asharif@chromium.org> wrote:
>>
>
>  > On 2010/07/09 19:20:51, asharif1 wrote:
>> >
>> >> On 2010/07/09 18:51:15, asharif1 wrote:
>> >> > I don't know why the linux build for ChromeBrowser is failing.
>> >> >
>> >> > At least for ChromeOS, r24 seems to be compiling just fine. I think
>> >> ChromeOS
>> >> > doesn't build the tests that are failing for ChromeBrowser.
>> >> >
>> >> > LGTM and commit this change because I don't have commit rights.
>> >>
>> >
>> >  Nevermind, it also produces a linker error just like the trybot for
>> >> ChromeBrowser.
>> >>
>> >
>> >  Pthatcher, can you take a look at this?
>> >>
>> >
>> > Okay, it seems like the GYP file in libjingle does not contain the
>> > sessionmessages.cc file which means it will not get compiled.
>> >
>> > So at link time the linker cannot find the definitions for the functions
>> in
>> > that
>> > file.
>> >
>> > How can I update the gyp file in libjingle? (I believe adding
>> > sessionmessages.cc/h might fix this issue).
>> >
>> >
>> > http://codereview.chromium.org/2921004/show
>> >
>>
>
>
>
>
> http://codereview.chromium.org/2921004/show
>

[akalin (wrong akalin), 2010-07-09 20:11:27]

If it's necessary to have the version update work, it should be part of this CL.

Sergey or I can code review.  Make sure it passes the trybots, though.

On Fri, Jul 9, 2010 at 12:59 PM, asharif <asharif@chromium.org> wrote:
> Okay, that seems easy enough.
> Should I make a CL on codereview.chromium.org so you or Sergey can commit?
> I don't have commit rights.
>
> On Fri, Jul 9, 2010 at 12:57 PM, <akalin@chromium.org> wrote:
>>
>> You should just be able to edit the .gyp file like any other chrome file.
>>  Just
>> add sessionmessages.{h,cc} and parsing.{h,cc} in the right place and
>> you'll be
>> fine.
>>
>> On 2010/07/09 19:48:19, pthatcher_google.com wrote:
>>>
>>> I don't know how to change GYP files, but you should know that you'll
>>> have
>>> to add p2p/base/sessionmessages.cc and p2p/base/parsing.cc (with .h
>>> files).
>>
>>> Also, I'm going to cc Fred Akalin and Sergey Ulanov.  They have
>>> experience
>>> using libjingle, and might be able to help you more than me.  Also,
>>> Sergey
>>> has commit rights to code.google.com/p/libjingle.
>>
>>
>>> By the way, sorry that the latest code broke your build at this
>>> inopportune
>>> moment.  I hope we can get it fixed quickly.
>>
>>
>>> On Fri, Jul 9, 2010 at 12:40 PM, <mailto:asharif@chromium.org> wrote:
>>
>>> > On 2010/07/09 19:20:51, asharif1 wrote:
>>> >
>>> >> On 2010/07/09 18:51:15, asharif1 wrote:
>>> >> > I don't know why the linux build for ChromeBrowser is failing.
>>> >> >
>>> >> > At least for ChromeOS, r24 seems to be compiling just fine. I think
>>> >> ChromeOS
>>> >> > doesn't build the tests that are failing for ChromeBrowser.
>>> >> >
>>> >> > LGTM and commit this change because I don't have commit rights.
>>> >>
>>> >
>>> >  Nevermind, it also produces a linker error just like the trybot for
>>> >> ChromeBrowser.
>>> >>
>>> >
>>> >  Pthatcher, can you take a look at this?
>>> >>
>>> >
>>> > Okay, it seems like the GYP file in libjingle does not contain the
>>> > sessionmessages.cc file which means it will not get compiled.
>>> >
>>> > So at link time the linker cannot find the definitions for the
>>> > functions in
>>> > that
>>> > file.
>>> >
>>> > How can I update the gyp file in libjingle? (I believe adding
>>> > sessionmessages.cc/h might fix this issue).
>>> >
>>> >
>>> > http://codereview.chromium.org/2921004/show
>>> >
>>
>>
>>
>>
>> http://codereview.chromium.org/2921004/show
>
>



-- 
Frederick Akalin
Software Engineer

[Sergey Ulanov, 2010-07-09 20:27:07]

Ahmad,
Can you please provide more details on the problem you are trying to solve?
I.e. what is broken without SessionMessage class?
The change looks good to me, I'll check it in.

On Fri, Jul 9, 2010 at 12:47 PM, Peter Thatcher <pthatcher@google.com>wrote:

> I don't know how to change GYP files, but you should know that you'll have
> to add p2p/base/sessionmessages.cc and p2p/base/parsing.cc (with .h files).
>
> Also, I'm going to cc Fred Akalin and Sergey Ulanov.  They have experience
> using libjingle, and might be able to help you more than me.  Also, Sergey
> has commit rights to code.google.com/p/libjingle.
>
>
> By the way, sorry that the latest code broke your build at this inopportune
> moment.  I hope we can get it fixed quickly.
>
>
> On Fri, Jul 9, 2010 at 12:40 PM, <asharif@chromium.org> wrote:
>
>> On 2010/07/09 19:20:51, asharif1 wrote:
>>
>>> On 2010/07/09 18:51:15, asharif1 wrote:
>>> > I don't know why the linux build for ChromeBrowser is failing.
>>> >
>>> > At least for ChromeOS, r24 seems to be compiling just fine. I think
>>> ChromeOS
>>> > doesn't build the tests that are failing for ChromeBrowser.
>>> >
>>> > LGTM and commit this change because I don't have commit rights.
>>>
>>
>>  Nevermind, it also produces a linker error just like the trybot for
>>> ChromeBrowser.
>>>
>>
>>  Pthatcher, can you take a look at this?
>>>
>>
>> Okay, it seems like the GYP file in libjingle does not contain the
>> sessionmessages.cc file which means it will not get compiled.
>>
>> So at link time the linker cannot find the definitions for the functions
>> in that
>> file.
>>
>> How can I update the gyp file in libjingle? (I believe adding
>> sessionmessages.cc/h might fix this issue).
>>
>>
>> http://codereview.chromium.org/2921004/show
>>
>
>

[pthatcher, 2010-07-09 20:30:44]

I pushed a new libjingle snapshot but forgot to add a few new files.  That's
been fixed now with a new push to libjingle.

But I guess now those files need to be added to a GYP file somewhere.  Since
I have no knowledge of the Chrome code base, I can't help much with that, so
I referred them to you, since you're also on the chrome code base using
libjingle.



On Fri, Jul 9, 2010 at 1:26 PM, Sergey Ulanov <sergeyu@chromium.org> wrote:

> Ahmad,
> Can you please provide more details on the problem you are trying to solve?
> I.e. what is broken without SessionMessage class?
> The change looks good to me, I'll check it in.
>
> On Fri, Jul 9, 2010 at 12:47 PM, Peter Thatcher <pthatcher@google.com>wrote:
>
>> I don't know how to change GYP files, but you should know that you'll have
>> to add p2p/base/sessionmessages.cc and p2p/base/parsing.cc (with .h files).
>>
>> Also, I'm going to cc Fred Akalin and Sergey Ulanov.  They have experience
>> using libjingle, and might be able to help you more than me.  Also, Sergey
>> has commit rights to code.google.com/p/libjingle.
>>
>>
>> By the way, sorry that the latest code broke your build at this
>> inopportune moment.  I hope we can get it fixed quickly.
>>
>>
>> On Fri, Jul 9, 2010 at 12:40 PM, <asharif@chromium.org> wrote:
>>
>>> On 2010/07/09 19:20:51, asharif1 wrote:
>>>
>>>> On 2010/07/09 18:51:15, asharif1 wrote:
>>>> > I don't know why the linux build for ChromeBrowser is failing.
>>>> >
>>>> > At least for ChromeOS, r24 seems to be compiling just fine. I think
>>>> ChromeOS
>>>> > doesn't build the tests that are failing for ChromeBrowser.
>>>> >
>>>> > LGTM and commit this change because I don't have commit rights.
>>>>
>>>
>>>  Nevermind, it also produces a linker error just like the trybot for
>>>> ChromeBrowser.
>>>>
>>>
>>>  Pthatcher, can you take a look at this?
>>>>
>>>
>>> Okay, it seems like the GYP file in libjingle does not contain the
>>> sessionmessages.cc file which means it will not get compiled.
>>>
>>> So at link time the linker cannot find the definitions for the functions
>>> in that
>>> file.
>>>
>>> How can I update the gyp file in libjingle? (I believe adding
>>> sessionmessages.cc/h might fix this issue).
>>>
>>>
>>> http://codereview.chromium.org/2921004/show
>>>
>>
>>
>

[asharif1, 2010-07-09 20:36:38]

pthatcher's reply pretty much summarizes the issue.

I have added the files to the GYP file and the try bot has successfully passed
the compilation change.

Let's wait for the full result of the trybot and then you can check in this
change (DEPS + GYP) if it LGTY.


On 2010/07/09 20:30:44, pthatcher_google.com wrote:
> I pushed a new libjingle snapshot but forgot to add a few new files.  That's
> been fixed now with a new push to libjingle.
> 
> But I guess now those files need to be added to a GYP file somewhere.  Since
> I have no knowledge of the Chrome code base, I can't help much with that, so
> I referred them to you, since you're also on the chrome code base using
> libjingle.
> 
> 
> 
> On Fri, Jul 9, 2010 at 1:26 PM, Sergey Ulanov <mailto:sergeyu@chromium.org>
wrote:
> 
> > Ahmad,
> > Can you please provide more details on the problem you are trying to solve?
> > I.e. what is broken without SessionMessage class?
> > The change looks good to me, I'll check it in.
> >
> > On Fri, Jul 9, 2010 at 12:47 PM, Peter Thatcher <pthatcher@google.com>wrote:
> >
> >> I don't know how to change GYP files, but you should know that you'll have
> >> to add p2p/base/sessionmessages.cc and p2p/base/parsing.cc (with .h files).
> >>
> >> Also, I'm going to cc Fred Akalin and Sergey Ulanov.  They have experience
> >> using libjingle, and might be able to help you more than me.  Also, Sergey
> >> has commit rights to code.google.com/p/libjingle.
> >>
> >>
> >> By the way, sorry that the latest code broke your build at this
> >> inopportune moment.  I hope we can get it fixed quickly.
> >>
> >>
> >> On Fri, Jul 9, 2010 at 12:40 PM, <mailto:asharif@chromium.org> wrote:
> >>
> >>> On 2010/07/09 19:20:51, asharif1 wrote:
> >>>
> >>>> On 2010/07/09 18:51:15, asharif1 wrote:
> >>>> > I don't know why the linux build for ChromeBrowser is failing.
> >>>> >
> >>>> > At least for ChromeOS, r24 seems to be compiling just fine. I think
> >>>> ChromeOS
> >>>> > doesn't build the tests that are failing for ChromeBrowser.
> >>>> >
> >>>> > LGTM and commit this change because I don't have commit rights.
> >>>>
> >>>
> >>>  Nevermind, it also produces a linker error just like the trybot for
> >>>> ChromeBrowser.
> >>>>
> >>>
> >>>  Pthatcher, can you take a look at this?
> >>>>
> >>>
> >>> Okay, it seems like the GYP file in libjingle does not contain the
> >>> sessionmessages.cc file which means it will not get compiled.
> >>>
> >>> So at link time the linker cannot find the definitions for the functions
> >>> in that
> >>> file.
> >>>
> >>> How can I update the gyp file in libjingle? (I believe adding
> >>> sessionmessages.cc/h might fix this issue).
> >>>
> >>>
> >>> http://codereview.chromium.org/2921004/show
> >>>
> >>
> >>
> >
>

[asharif1, 2010-07-10 02:06:48]

Can someone commit this patch now? Seems like the buildbot results are all
green.

On 2010/07/09 20:36:38, asharif1 wrote:
> pthatcher's reply pretty much summarizes the issue.
> 
> I have added the files to the GYP file and the try bot has successfully passed
> the compilation change.
> 
> Let's wait for the full result of the trybot and then you can check in this
> change (DEPS + GYP) if it LGTY.
> 
> 
> On 2010/07/09 20:30:44, http://pthatcher_google.com wrote:
> > I pushed a new libjingle snapshot but forgot to add a few new files.  That's
> > been fixed now with a new push to libjingle.
> > 
> > But I guess now those files need to be added to a GYP file somewhere.  Since
> > I have no knowledge of the Chrome code base, I can't help much with that, so
> > I referred them to you, since you're also on the chrome code base using
> > libjingle.
> > 
> > 
> > 
> > On Fri, Jul 9, 2010 at 1:26 PM, Sergey Ulanov <mailto:sergeyu@chromium.org>
> wrote:
> > 
> > > Ahmad,
> > > Can you please provide more details on the problem you are trying to
solve?
> > > I.e. what is broken without SessionMessage class?
> > > The change looks good to me, I'll check it in.
> > >
> > > On Fri, Jul 9, 2010 at 12:47 PM, Peter Thatcher
<pthatcher@google.com>wrote:
> > >
> > >> I don't know how to change GYP files, but you should know that you'll
have
> > >> to add p2p/base/sessionmessages.cc and p2p/base/parsing.cc (with .h
files).
> > >>
> > >> Also, I'm going to cc Fred Akalin and Sergey Ulanov.  They have
experience
> > >> using libjingle, and might be able to help you more than me.  Also,
Sergey
> > >> has commit rights to code.google.com/p/libjingle.
> > >>
> > >>
> > >> By the way, sorry that the latest code broke your build at this
> > >> inopportune moment.  I hope we can get it fixed quickly.
> > >>
> > >>
> > >> On Fri, Jul 9, 2010 at 12:40 PM, <mailto:asharif@chromium.org> wrote:
> > >>
> > >>> On 2010/07/09 19:20:51, asharif1 wrote:
> > >>>
> > >>>> On 2010/07/09 18:51:15, asharif1 wrote:
> > >>>> > I don't know why the linux build for ChromeBrowser is failing.
> > >>>> >
> > >>>> > At least for ChromeOS, r24 seems to be compiling just fine. I think
> > >>>> ChromeOS
> > >>>> > doesn't build the tests that are failing for ChromeBrowser.
> > >>>> >
> > >>>> > LGTM and commit this change because I don't have commit rights.
> > >>>>
> > >>>
> > >>>  Nevermind, it also produces a linker error just like the trybot for
> > >>>> ChromeBrowser.
> > >>>>
> > >>>
> > >>>  Pthatcher, can you take a look at this?
> > >>>>
> > >>>
> > >>> Okay, it seems like the GYP file in libjingle does not contain the
> > >>> sessionmessages.cc file which means it will not get compiled.
> > >>>
> > >>> So at link time the linker cannot find the definitions for the functions
> > >>> in that
> > >>> file.
> > >>>
> > >>> How can I update the gyp file in libjingle? (I believe adding
> > >>> sessionmessages.cc/h might fix this issue).
> > >>>
> > >>>
> > >>> http://codereview.chromium.org/2921004/show
> > >>>
> > >>
> > >>
> > >
> >

[piman, 2010-07-10 23:59:01]

On Fri, Jul 9, 2010 at 7:06 PM, <asharif@chromium.org> wrote:

> Can someone commit this patch now? Seems like the buildbot results are all
> green.
>
> I'll check it in on monday.

Antoine


>
> On 2010/07/09 20:36:38, asharif1 wrote:
>
>> pthatcher's reply pretty much summarizes the issue.
>>
>
>  I have added the files to the GYP file and the try bot has successfully
>> passed
>> the compilation change.
>>
>
>  Let's wait for the full result of the trybot and then you can check in
>> this
>> change (DEPS + GYP) if it LGTY.
>>
>
>
>  On 2010/07/09 20:30:44, http://pthatcher_google.com wrote:
>> > I pushed a new libjingle snapshot but forgot to add a few new files.
>>  That's
>> > been fixed now with a new push to libjingle.
>> >
>> > But I guess now those files need to be added to a GYP file somewhere.
>>  Since
>> > I have no knowledge of the Chrome code base, I can't help much with
>> that, so
>> > I referred them to you, since you're also on the chrome code base using
>> > libjingle.
>> >
>> >
>> >
>> > On Fri, Jul 9, 2010 at 1:26 PM, Sergey Ulanov <mailto:
>> sergeyu@chromium.org>
>> wrote:
>> >
>> > > Ahmad,
>> > > Can you please provide more details on the problem you are trying to
>>
> solve?
>
>> > > I.e. what is broken without SessionMessage class?
>> > > The change looks good to me, I'll check it in.
>> > >
>> > > On Fri, Jul 9, 2010 at 12:47 PM, Peter Thatcher
>>
> <pthatcher@google.com>wrote:
>
>> > >
>> > >> I don't know how to change GYP files, but you should know that you'll
>>
> have
>
>> > >> to add p2p/base/sessionmessages.cc and p2p/base/parsing.cc (with .h
>>
> files).
>
>> > >>
>> > >> Also, I'm going to cc Fred Akalin and Sergey Ulanov.  They have
>>
> experience
>
>> > >> using libjingle, and might be able to help you more than me.  Also,
>>
> Sergey
>
>> > >> has commit rights to code.google.com/p/libjingle.
>> > >>
>> > >>
>> > >> By the way, sorry that the latest code broke your build at this
>> > >> inopportune moment.  I hope we can get it fixed quickly.
>> > >>
>> > >>
>> > >> On Fri, Jul 9, 2010 at 12:40 PM, <mailto:asharif@chromium.org>
>> wrote:
>> > >>
>> > >>> On 2010/07/09 19:20:51, asharif1 wrote:
>> > >>>
>> > >>>> On 2010/07/09 18:51:15, asharif1 wrote:
>> > >>>> > I don't know why the linux build for ChromeBrowser is failing.
>> > >>>> >
>> > >>>> > At least for ChromeOS, r24 seems to be compiling just fine. I
>> think
>> > >>>> ChromeOS
>> > >>>> > doesn't build the tests that are failing for ChromeBrowser.
>> > >>>> >
>> > >>>> > LGTM and commit this change because I don't have commit rights.
>> > >>>>
>> > >>>
>> > >>>  Nevermind, it also produces a linker error just like the trybot for
>> > >>>> ChromeBrowser.
>> > >>>>
>> > >>>
>> > >>>  Pthatcher, can you take a look at this?
>> > >>>>
>> > >>>
>> > >>> Okay, it seems like the GYP file in libjingle does not contain the
>> > >>> sessionmessages.cc file which means it will not get compiled.
>> > >>>
>> > >>> So at link time the linker cannot find the definitions for the
>> functions
>> > >>> in that
>> > >>> file.
>> > >>>
>> > >>> How can I update the gyp file in libjingle? (I believe adding
>> > >>> sessionmessages.cc/h might fix this issue).
>> > >>>
>> > >>>
>> > >>> http://codereview.chromium.org/2921004/show
>> > >>>
>> > >>
>> > >>
>> > >
>> >
>>
>
>
>
> http://codereview.chromium.org/2921004/show
>

[Sergey Ulanov, 2010-07-12 17:10:22]

Checked in: http://src.chromium.org/viewvc/chrome?view=rev&revision=52089