Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2919005: Use file_util::GetHomeDir instead of getenv("HOME"). (Closed)

Created:
10 years, 5 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, kuchhal, ben+cc_chromium.org, brettw-cc_chromium.org
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

Use file_util::GetHomeDir instead of getenv("HOME"). BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M base/mime_util_xdg.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/nss_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Hi Lei, could you review this to me?
10 years, 5 months ago (2010-07-11 01:00:54 UTC) #1
Lei Zhang
10 years, 5 months ago (2010-07-12 17:57:20 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698