Issue 2918005: Button label logic on mac should match other platforms and show "stop syncing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2918005: Button label logic on mac should match other platforms and show "stop syncing... (Closed)

Created:
10 years, 5 months ago by John Gregg

Modified:
9 years ago

Reviewers:
akalin, tim (not reviewing)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Button label logic on mac should match other platforms and show "stop syncing" whenever sync setup is done, regardless of error state. BUG=48973 TEST=invalidate login creds on mac, check options panel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52262

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/cocoa/preferences_window_controller.mm	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2010/07/13 19:07:05, John Gregg wrote:
>

Expand Messages | Collapse Messages