Issue 2917010: AutoFill: Add credit card images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2917010: AutoFill: Add credit card images. (Closed)

Created:
10 years, 5 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

Description

AutoFill: Add credit card images. BUG=48015 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52213

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -0 lines)		Patch
A	chrome/browser/resources/amex.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/cc-generic.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/diners.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/discover.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/jcb.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/mastercard.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/solo.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/visa.png	View	Binary file	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dhollowa

These are a mix of dimensions. I would have expected uniform dimensions for each CC ...

10 years, 5 months ago (2010-07-13 20:34:36 UTC) #2

James Hawkins

On 2010/07/13 20:34:36, dhollowa wrote: > These are a mix of dimensions. I would have ...

10 years, 5 months ago (2010-07-13 20:35:29 UTC) #3

dhollowa

10 years, 5 months ago (2010-07-13 20:38:10 UTC) #4

On 2010/07/13 20:35:29, James Hawkins wrote:
> On 2010/07/13 20:34:36, dhollowa wrote:
> > These are a mix of dimensions.  I would have expected uniform dimensions for
> > each CC type.  I.e. 26x16 pixels.  Problem?
> 
> No, the drawing code will center the image horizontally and right-justify it.

The cc-generic.png is noticeably smaller than the rest.

But LGTM if you're fine with it.

Expand Messages | Collapse Messages