Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2917009: Reapply gclient.py refactor for the third time. (Closed)

Created:
10 years, 5 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, tony
Visibility:
Public.

Description

Reapply gclient.py refactor for the third time. Bring some OOP and sanity to gclient.py. - Changed the algorithm from breadth-first to depth-first. - Added infinite recursion support. - Fixed From() of From() dependency. - Fixed cross solution custom deps aliasing. - Removed support code for old .gclient_entries format. - Removed IsGitCheckout() in favor for a direct check for .git presence. TEST=all test pass The main difference with r51760 is that new smoke tests have been added since which replicates how webkit checkouts with gclient. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53205

Patch Set 1 #

Patch Set 2 : Rebased on HEAD #

Patch Set 3 : Now passes the much more stringent smoke tests that imitates webkit checkout #

Patch Set 4 : Fix runhooks with hooks defined in From(File()) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -307 lines) Patch
M gclient.py View 1 2 3 12 chunks +224 lines, -295 lines 0 comments Download
M gclient_utils.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/gclient_smoketest.py View 1 3 chunks +1 line, -3 lines 0 comments Download
M tests/gclient_utils_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
The interesting diff is gclient.py patchset 4 against patchset 2. The rest is the same ...
10 years, 5 months ago (2010-07-12 20:13:09 UTC) #1
Mandeep Singh Baines
10 years, 5 months ago (2010-07-13 20:26:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698