Issue 2917008: build_image, build_kernel_image, legacy_bootloaders: Rename vboot flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2917008: build_image, build_kernel_image, legacy_bootloaders: Rename vboot flags (Closed)

Created:
10 years, 5 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

build_image, build_kernel_image, legacy_bootloaders: Rename vboot flags The use_vboot and vboot_ flags were confusing from a functionality perspective since verified boot as a feature encompasses firmware and kernel functionality. The firmware bits are always enabled, but use_vboot enabled the image-integrity portion of vboot. It is not called --enable_rootfs_verification and all options for the kernel functionality is under --verity_* given that verity/dm-verity is the current working name for the module and userspace tool. TEST=ran x86-generic build_image & tegra2-dev-board build_image and checked the resulting boot.config files (with and without --enable_rootfs_verification). BUG=chromium-os:2693

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated the descriptions #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -44 lines)			Patch
M	build_image	View	1	4 chunks	+20 lines, -17 lines	0 comments	Download
M	build_kernel_image.sh	View		4 chunks	+13 lines, -13 lines	0 comments	Download
M	create_legacy_bootloader_templates.sh	View		8 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

LGTM, thanks! http://codereview.chromium.org/2917008/diff/1/2 File build_image (right): http://codereview.chromium.org/2917008/diff/1/2#newcode66 build_image:66: "Default the bootloaders to booting a verifying ...

10 years, 5 months ago (2010-07-09 20:00:07 UTC) #3

Will Drewry

10 years, 5 months ago (2010-07-09 20:07:59 UTC) #4

On 2010/07/09 20:00:07, Randall Spangler wrote:
> LGTM, thanks!
> 
> http://codereview.chromium.org/2917008/diff/1/2
> File build_image (right):
> 
> http://codereview.chromium.org/2917008/diff/1/2#newcode66
> build_image:66: "Default the bootloaders to booting a verifying kernel.
Default:
> False."
> Suggested reword:
> to use kernel-based rootfs verification

Updated the descriptions.

Expand Messages | Collapse Messages