Issue 2913: Use a variant_dir when building gears.dll so building the different ports...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2913: Use a variant_dir when building gears.dll so building the different ports... (Closed)

Created:
12 years, 3 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use a variant_dir when building gears.dll so building the different ports don't clobber each other. Also added FF2 and FF3 support. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2453

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -1217 lines)			Patch
M	gears/SConscript	View	1 2	6 chunks	+30 lines, -1068 lines	0 comments	Download
A +	gears/SConscript.dll	View	1 2	8 chunks	+17 lines, -148 lines	1 comment	Download
M	gears/SConscript.sqlite	View		4 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

I also updated the SQLite build script since Gears is using a newer version now.

12 years, 3 months ago (2008-09-17 19:21:12 UTC) #1

sgk

12 years, 3 months ago (2008-09-22 19:28:57 UTC) #2

lgtm

http://codereview.chromium.org/2913/diff/206/10
File gears/SConscript.dll (right):

http://codereview.chromium.org/2913/diff/206/10#newcode47
Line 47: print 'path=', env['ENV']['PATH']
leftover debug print?

Expand Messages | Collapse Messages