Issue 2912: add a new xcconfig to build c++ files as obj-c++ to ensure correct linkage. B...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2912: add a new xcconfig to build c++ files as obj-c++ to ensure correct linkage. B... (Closed)

Created:
12 years, 3 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

add a new xcconfig to build c++ files as obj-c++ to ensure correct linkage. Be more specific when using an overloaded operator since objective-c++ finds conflicts. Enable objective-C GC in our common config file for all projects. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2305

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -3 lines)			Patch
M	build/common.xcconfig	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/editor_client_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/webkit.xcodeproj/project.pbxproj	View	4 chunks	+4 lines, -2 lines	0 comments	Download
A	webkit/webkit_staticlib.xcconfig	View	1 chunk	+12 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

lgo http://codereview.chromium.org/2912/diff/6/205 File webkit/webkit_staticlib.xcconfig (right): http://codereview.chromium.org/2912/diff/6/205#newcode1 Line 1: // Copyright (c) 2008 The Chromium Authors. ...

12 years, 3 months ago (2008-09-16 21:26:30 UTC) #2

pink (ping after 24hrs)

12 years, 3 months ago (2008-09-16 21:47:30 UTC) #3

On 2008/09/16 21:26:30, Mark Mentovai wrote:
> lgo
> 
> http://codereview.chromium.org/2912/diff/6/205
> File webkit/webkit_staticlib.xcconfig (right):
> 
> http://codereview.chromium.org/2912/diff/6/205#newcode1
> Line 1: // Copyright (c) 2008 The Chromium Authors. All rights reserved.
> I think we should put this file inside the webkit.xcodeproj directory - we
have
> precedent for doing that with our new shiny build scripts.

I don't like that putting it inside the project package hides the file from
spotlight and any text indexing. I'd prefer to keep it visible so it can be
easily located.

Expand Messages | Collapse Messages