Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2911011: Build OSMesa on all platforms and not just on bots.... (Closed)

Created:
10 years, 5 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Build OSMesa on all platforms and not just on bots. It was only built on Windows bots before. The new --use-gl switch will now prevent Chrome from using it by default if it finds the shared library, which was the previous behavior. TEST=try BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52568

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/all.gyp View 2 chunks +1 line, -3 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
apatrick_chromium
10 years, 5 months ago (2010-07-14 21:29:37 UTC) #1
Ken Russell (switch to Gerrit)
LGTM http://codereview.chromium.org/2911011/diff/1/2 File build/all.gyp (right): http://codereview.chromium.org/2911011/diff/1/2#newcode40 build/all.gyp:40: '../third_party/mesa/mesa.gyp:*', Would it be better to depend explicitly ...
10 years, 5 months ago (2010-07-15 03:27:48 UTC) #2
apatrick_chromium
10 years, 5 months ago (2010-07-15 19:26:20 UTC) #3
http://codereview.chromium.org/2911011/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/2911011/diff/1/2#newcode40
build/all.gyp:40: '../third_party/mesa/mesa.gyp:*',
On 2010/07/15 03:27:48, kbr wrote:
> Would it be better to depend explicitly on the osmesa target like before?
> 
The convention for the All target is to depend on everything in the referenced
gyp files. In this case depending on the osmesa target would have the same
effect since osmesa is dependent on mesa but I went with consistency.

Powered by Google App Engine
This is Rietveld 408576698