Issue 2908011: Replaced static wstring with wchar_t*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2908011: Replaced static wstring with wchar_t*. (Closed)

Created:
10 years, 5 months ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews, Sergey Ulanov, dmac, garykac, Alpha Left Google, tfarina

Visibility:
Public.

Description

Replaced static wstring with wchar_t*. BUG=None TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54007

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	remoting/host/host_config.h	View		1 chunk	+5 lines, -5 lines	1 comment	Download
	M	remoting/host/host_config.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

10 years, 5 months ago (2010-07-16 22:48:07 UTC) #3

http://codereview.chromium.org/2908011/diff/1/3
File remoting/host/host_config.h (right):

http://codereview.chromium.org/2908011/diff/1/3#newcode19
remoting/host/host_config.h:19: extern const wchar_t* kXmppLoginConfigPath;
please, use wchar_t kFoo[]

Expand Messages | Collapse Messages