Issue 2908003: Video Buffering: Caches data to disk when paused (resubmit)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2908003: Video Buffering: Caches data to disk when paused (resubmit) (Closed)

Created:
10 years, 5 months ago by vrk (LEFT CHROMIUM)

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, Alpha Left Google

Visibility:
Public.

Description

Video Buffering: Caches data to disk when paused (resubmit) Resubmitting this buffering patch because original patch was reverted. This patch clears up the memory leak issue in the unit tests and adds valgrind suppressions to silence the uninitialized variable false positives. BUG=42285 TEST=test_shell_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52569

Patch Set 1 #

Patch Set 2 : Added bug number to valgrind bug, also fixed spacing issue #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -5 lines)			Patch
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	webkit/glue/media/buffered_data_source.h	View		7 chunks	+17 lines, -1 line	0 comments	Download
M	webkit/glue/media/buffered_data_source.cc	View		10 chunks	+46 lines, -3 lines	0 comments	Download
M	webkit/glue/media/buffered_data_source_unittest.cc	View		4 chunks	+146 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

Have you filed a bug against valgrind for the false positive? We generally report any ...

10 years, 5 months ago (2010-07-08 22:28:07 UTC) #2

vrk (LEFT CHROMIUM)

10 years, 5 months ago (2010-07-09 01:53:34 UTC) #4

Hi Stuart! I had not filed a bug, but I just did. I also updated
suppressions.txt accordingly with the bug number as well. Thanks!

On 2010/07/08 22:28:07, stuartmorgan wrote:
> Have you filed a bug against valgrind for the false positive? We generally
> report any valgrind bugs we find and link to the bugs in the suppressions.

Expand Messages | Collapse Messages