Issue 2907005: Use PKG_INSTALL_MASK to prevent debug symbols from getting into the binpkg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2907005: Use PKG_INSTALL_MASK to prevent debug symbols from getting into the binpkg. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, Chris Masone, Nikita (slow)

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

Use PKG_INSTALL_MASK to prevent debug symbols from getting into the binpkg. The mask is set only if it's not set already. Also, it picks up the default install mask from common.sh. BUG=none TEST=gmerged chromeos-chrome with PKG_INSTALL_MASK set/unset.

Patch Set 1 #

Patch Set 2 : fix the test for a set variable. #

Total comments: 4

Patch Set 3 : Remove duplicate mask and add a comment. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	start_devserver	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kmixter1

LGTM http://codereview.chromium.org/2907005/diff/2001/3001 File start_devserver (right): http://codereview.chromium.org/2907005/diff/2001/3001#newcode36 start_devserver:36: if [ -z "${PKG_INSTALL_MASK+x}" ]; then what does ...

10 years, 5 months ago (2010-07-08 22:01:49 UTC) #2

petkov

10 years, 5 months ago (2010-07-08 22:10:17 UTC) #3

http://codereview.chromium.org/2907005/diff/2001/3001
File start_devserver (right):

http://codereview.chromium.org/2907005/diff/2001/3001#newcode36
start_devserver:36: if [ -z "${PKG_INSTALL_MASK+x}" ]; then
On 2010/07/08 22:01:51, kmixter1 wrote:
> what does +x do?

This is a way I found to test if a variable is set or not. Basically, if
PKG_INSTALL_MASK is set, this expands to nothing. If it's unset, this expands to
"x". "x" is irrelevant. Added a comment.

Is there a better way to do this?

http://codereview.chromium.org/2907005/diff/2001/3001#newcode37
start_devserver:37: export PKG_INSTALL_MASK="${DEFAULT_INSTALL_MASK}
/usr/lib/debug"
On 2010/07/08 22:01:51, kmixter1 wrote:
> /usr/lib/debug is already in the DEFAULT_INSTALL_MASK.

Done. I'm too eager to move on, I guess, should have checked more carefully. And
I'm printing it!

Expand Messages | Collapse Messages