Issue 2904015: Fix bug in Object.isFrozen which always classifies non-extensible objects as ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2904015: Fix bug in Object.isFrozen which always classifies non-extensible objects as ... (Closed)

Created:
10 years, 5 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bug in Object.isFrozen which always classifies non-extensible objects as frozen. Since out internal representation of a property descriptor does not have configurable and writable attributes Object.isFrozen returns true whenever an object is not extensible. This change makes use of the right method calls on our internal representation (isWritable() and isConfigurable()). Tests added directly to the mjsunit test. Committed: http://code.google.com/p/v8/source/detail?r=5068

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	src/v8natives.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	test/mjsunit/object-freeze.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages