Issue 2904013: Don't set the URL on folders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2904013: Don't set the URL on folders. (Closed)

Created:
10 years, 5 months ago by ncarter (slow)

Modified:
9 years, 7 months ago

Reviewers:
akalin

CC:
chromium-reviews, Raghu Simha, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Don't set the URL on folders, even to an empty string. This suppresses a harmless LOG(ERROR) on SPECIFICS / SERVER_SPECIFICS not matching. That's because the server doesn't return preserve a URL field on folder entities, so if we set it locally (even to the empty string), it won't be returned in the result message. BUG=45610 TEST=create a folder, rename it, verify no 'LOG(WARNING) << "Specifics mismatch"' from syncer_util.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52269

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/sync/glue/bookmark_change_processor.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

Don't set the URL on folders, even to an empty string. This suppresses a harmless ...

10 years, 5 months ago (2010-07-14 01:09:30 UTC) #1

akalin

10 years, 5 months ago (2010-07-14 01:50:49 UTC) #2

LGTM

On 2010/07/14 01:09:30, ncarter wrote:
> Don't set the URL on folders, even to an empty string.
> 
> This suppresses a harmless LOG(ERROR) on SPECIFICS / SERVER_SPECIFICS not
> matching.  That's because the server doesn't return preserve a URL field on
> folder entities, so if we set it locally (even to the empty string), it won't
be
> returned in the result message.

Expand Messages | Collapse Messages